Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with TiCon smeltery disabled #411

Open
GrumpyChunks opened this issue Jan 2, 2019 · 1 comment
Open

Crash with TiCon smeltery disabled #411

GrumpyChunks opened this issue Jan 2, 2019 · 1 comment

Comments

@GrumpyChunks
Copy link

I've installed base & modern metals (2.5.0 beta 6) along side tinkers' 1.12.1-2.11.0.106, but have modified tinkersmodules.cfg to disable the smeltery. This causes a crash.

I don't have any other mods that add ores of any kind other than base & modern metals.

I can prevent the crash in two ways.

  1. Enable the smeltery, which I really don't want to enable in my modpack
  2. Disable the Tinkers' integration in the base metals config (which disables most of the material traits for Tinkers' tools, which then essentially makes base & modern metals mostly redundant.

I've tried combinations of disabling liquids (in both base & modern metals) with the above, hoping to find a happy medium.

Would it be possible to make the Tinkers' integration detect the smeltery being disabled, and make the integration selective, or even add a separate option for smeltery integration?

@dshadowwolf
Copy link
Collaborator

I'll have to do some testing, but the only thing I can think of that might cause this is our attempts to register some of the extended bits (swords, armor, etc...) for smelting - there is an assumption in our code that TiCon's API handles sorting out stuff that it isn't configured to support and our code should not have to know how TiCon is configured.

But we should be more... stable in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants