[JitDiff X64] [EgorBo] Intrinsify Enum.Equals to avoid boxing

[MihuBot]

Job completed in 16 minutes 57 seconds (remote runner delay: 1 minute 7 seconds).
dotnet/runtime#122779

Main commit: dotnet/runtime@38489b9
PR commit: EgorBo/runtime-1@e6ed7a9

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 45255588
Total bytes of diff: 45255487
Total bytes of delta: -101 (-0.00 % of base)
Total relative delta: -0.45
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
        -101 : System.ComponentModel.TypeConverter.dasm (-0.03 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method improvements (bytes):
        -101 (-45.50 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this (FullOpts)

Top method improvements (percentages):
        -101 (-45.50 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this (FullOpts)

1 total methods with Code Size differences (1 improved, 0 regressed), 283303 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• jit-diffs-pr.zip (154 MB)
• jit-diffs-main.zip (154 MB)
• diff-frameworks.txt (1 KB)
• ShortDiffsImprovements.md (8 KB)

[MihuBot]

Top method improvements

-101 (-45.50 % of base) - System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this

 ; Assembly listing for method System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this (FullOpts)
 ; Emitting BLENDED_CODE for generic X64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 7 single block inlinees; 1 inlinees without PGO data
 ; Final local variable assignments
 ;
-;  V00 this         [V00,T01] (  5,  4   )     ref  ->  rbx         this class-hnd single-def <System.ComponentModel.ToolboxItemFilterAttribute>
+;  V00 this         [V00,T01] (  5,  4   )     ref  ->  rdi         this class-hnd single-def <System.ComponentModel.ToolboxItemFilterAttribute>
 ;  V01 arg1         [V01,T00] (  6,  4.25)     ref  ->  rsi         class-hnd single-def <System.Object>
-;  V02 loc0         [V02,T08] (  3,  1.50)     ref  ->  r15         class-hnd exact <System.ComponentModel.ToolboxItemFilterAttribute>
-;  V03 loc1         [V03,T10] (  2,  1   )     int  ->  r14         ld-addr-op
+;  V02 loc0         [V02,T06] (  3,  1.50)     ref  ->  rsi         class-hnd exact <System.ComponentModel.ToolboxItemFilterAttribute>
+;  V03 loc1         [V03,T08] (  2,  1   )     int  ->  rdx         ld-addr-op
 ;# V04 OutArgs      [V04    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;* V05 tmp1         [V05    ] (  0,  0   )     ref  ->  zero-ref    class-hnd "spilling qmarkNull" <System.ComponentModel.ToolboxItemFilterAttribute>
-;  V06 tmp2         [V06,T04] (  3,  3   )     ref  ->  r13         class-hnd exact single-def "Single-def Box Helper" <System.ComponentModel.ToolboxItemFilterType>
-;  V07 tmp3         [V07,T05] (  3,  3   )     ref  ->  rax         class-hnd exact single-def "Single-def Box Helper" <System.ComponentModel.ToolboxItemFilterType>
-;  V08 tmp4         [V08,T02] (  5,  5   )     ref  ->  rdi         class-hnd exact single-def "impAppendStmt" <System.String>
-;  V09 tmp5         [V09,T06] (  4,  2   )   ubyte  ->  rax         "Inline return value spill temp"
+;* V06 tmp2         [V06    ] (  0,  0   )    long  ->  zero-ref    class-hnd exact "Single-def Box Helper" <System.ComponentModel.ToolboxItemFilterType>
+;* V07 tmp3         [V07    ] (  0,  0   )    long  ->  zero-ref    class-hnd exact "Single-def Box Helper" <System.ComponentModel.ToolboxItemFilterType>
+;  V08 tmp4         [V08,T02] (  5,  5   )     ref  ->  rdx         class-hnd exact single-def "impAppendStmt" <System.String>
+;  V09 tmp5         [V09,T04] (  4,  2   )   ubyte  ->  rax         "Inline return value spill temp"
 ;  V10 tmp6         [V10,T03] (  5,  5   )     ref  ->  rsi         class-hnd exact single-def "Inlining Arg" <System.String>
-;  V11 tmp7         [V11,T07] (  2,  2   )   byref  ->  rdi         single-def "impAppendStmt"
-;  V12 cse0         [V12,T09] (  3,  1.50)     int  ->  rdx         "CSE #02: moderate"
+;  V11 tmp7         [V11,T05] (  2,  2   )   byref  ->  rax         single-def "impAppendStmt"
+;* V12 tmp8         [V12    ] (  0,  0   )  struct (16) zero-ref    do-not-enreg[SF] "stack allocated [boxed] System.ComponentModel.ToolboxItemFilterType" <[boxed] System.ComponentModel.ToolboxItemFilterType>
+;* V13 tmp9         [V13    ] (  0,  0   )  struct (16) zero-ref    do-not-enreg[SF] "stack allocated [boxed] System.ComponentModel.ToolboxItemFilterType" <[boxed] System.ComponentModel.ToolboxItemFilterType>
+;* V14 tmp10        [V14    ] (  0,  0   )    long  ->  zero-ref    "V12.[000..008)"
+;  V15 tmp11        [V15,T09] (  2,  1   )     int  ->  rax         "V12.[008..012)"
+;* V16 tmp12        [V16    ] (  0,  0   )    long  ->  zero-ref    "V13.[000..008)"
+;* V17 tmp13        [V17    ] (  0,  0   )     int  ->  zero-ref    "V13.[008..012)"
+;  V18 cse0         [V18,T07] (  3,  1.50)     int  ->  rdi         "CSE #01: moderate"
 ;
 ; Lcl frame size = 0
 
 G_M25673_IG01:
        push     rbp
-       push     r15
-       push     r14
-       push     r13
-       push     rbx
-       lea      rbp, [rsp+0x20]
-       mov      rbx, rdi
-						;; size=16 bbWeight=1 PerfScore 5.75
+       mov      rbp, rsp
+						;; size=4 bbWeight=1 PerfScore 1.25
 G_M25673_IG02:
-       cmp      rsi, rbx
-       je       G_M25673_IG11
-						;; size=9 bbWeight=1 PerfScore 1.25
+       cmp      rsi, rdi
+       je       SHORT G_M25673_IG11
+						;; size=5 bbWeight=1 PerfScore 1.25
 G_M25673_IG03:
        test     rsi, rsi
-       je       G_M25673_IG09
-						;; size=9 bbWeight=0.50 PerfScore 0.62
-G_M25673_IG04:
-       mov      rdi, 0xD1FFAB1E      ; System.ComponentModel.ToolboxItemFilterAttribute
-       cmp      qword ptr [rsi], rdi
-       jne      G_M25673_IG09
-						;; size=19 bbWeight=0.25 PerfScore 1.06
-G_M25673_IG05:
-       mov      r15, rsi
-       mov      r14d, dword ptr [r15+0x18]
-       mov      rdi, 0xD1FFAB1E      ; System.ComponentModel.ToolboxItemFilterType
-       call     CORINFO_HELP_NEWSFAST
-       mov      r13, rax
-       mov      edi, dword ptr [rbx+0x18]
-       mov      dword ptr [r13+0x08], edi
-       mov      rdi, 0xD1FFAB1E      ; System.ComponentModel.ToolboxItemFilterType
-       call     CORINFO_HELP_NEWSFAST
-       mov      dword ptr [rax+0x08], r14d
-       mov      rdi, rax
-       mov      rsi, r13
-       mov      rax, 0xD1FFAB1E      ; code for System.Enum:Equals(System.Object):bool:this
-       call     [rax]System.Enum:Equals(System.Object):bool:this
-       test     eax, eax
        je       SHORT G_M25673_IG09
-       mov      rdi, gword ptr [r15+0x08]
-       mov      rsi, gword ptr [rbx+0x08]
-       cmp      byte  ptr [rdi], dil
-       cmp      rdi, rsi
+						;; size=5 bbWeight=0.50 PerfScore 0.62
+G_M25673_IG04:
+       mov      rdx, 0xD1FFAB1E      ; System.ComponentModel.ToolboxItemFilterAttribute
+       cmp      qword ptr [rsi], rdx
+       jne      SHORT G_M25673_IG09
+						;; size=15 bbWeight=0.25 PerfScore 1.06
+G_M25673_IG05:
+       mov      edx, dword ptr [rsi+0x18]
+       mov      eax, dword ptr [rdi+0x18]
+       cmp      edx, eax
+       jne      SHORT G_M25673_IG09
+       mov      rdx, gword ptr [rsi+0x08]
+       mov      rsi, gword ptr [rdi+0x08]
+       cmp      byte  ptr [rdx], dl
+       cmp      rdx, rsi
        je       SHORT G_M25673_IG07
        test     rsi, rsi
        je       SHORT G_M25673_IG06
-       mov      edx, dword ptr [rdi+0x08]
-       cmp      edx, dword ptr [rsi+0x08]
+       mov      edi, dword ptr [rdx+0x08]
+       cmp      edi, dword ptr [rsi+0x08]
        jne      SHORT G_M25673_IG06
-       add      rdi, 12
-       add      edx, edx
+       add      rdx, 12
+       mov      rax, rdx
+       add      edi, edi
+       mov      edx, edi
        add      rsi, 12
+       mov      rdi, rax
        mov      rax, 0xD1FFAB1E      ; code for System.SpanHelpers:SequenceEqual(byref,byref,nuint):bool
        call     [rax]System.SpanHelpers:SequenceEqual(byref,byref,nuint):bool
        jmp      SHORT G_M25673_IG08
-						;; size=126 bbWeight=0.50 PerfScore 17.75
+						;; size=70 bbWeight=0.50 PerfScore 13.75
 G_M25673_IG06:
        xor      eax, eax
        jmp      SHORT G_M25673_IG08
 						;; size=4 bbWeight=0.50 PerfScore 1.12
 G_M25673_IG07:
        mov      eax, 1
 						;; size=5 bbWeight=0.50 PerfScore 0.12
 G_M25673_IG08:
-       pop      rbx
-       pop      r13
-       pop      r14
-       pop      r15
        pop      rbp
        ret      
-						;; size=9 bbWeight=0.50 PerfScore 1.75
+						;; size=2 bbWeight=0.50 PerfScore 0.75
 G_M25673_IG09:
        xor      eax, eax
 						;; size=2 bbWeight=0.50 PerfScore 0.12
 G_M25673_IG10:
-       pop      rbx
-       pop      r13
-       pop      r14
-       pop      r15
        pop      rbp
        ret      
-						;; size=9 bbWeight=0.50 PerfScore 1.75
+						;; size=2 bbWeight=0.50 PerfScore 0.75
 G_M25673_IG11:
        mov      eax, 1
 						;; size=5 bbWeight=0.50 PerfScore 0.12
 G_M25673_IG12:
-       pop      rbx
-       pop      r13
-       pop      r14
-       pop      r15
        pop      rbp
        ret      
-						;; size=9 bbWeight=0.50 PerfScore 1.75
+						;; size=2 bbWeight=0.50 PerfScore 0.75
 
-; Total bytes of code 222, prolog size 13, PerfScore 33.19, instruction count 69, allocated bytes for code 222 (MethodHash=43ac9bb6) for method System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this (FullOpts)
+; Total bytes of code 121, prolog size 4, PerfScore 21.69, instruction count 43, allocated bytes for code 121 (MethodHash=43ac9bb6) for method System.ComponentModel.ToolboxItemFilterAttribute:Equals(System.Object):bool:this (FullOpts)
 ; ============================================================

[MihuBot]

@EgorBo