Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaultwarden version not displayed in admin panel (or anywhere?) #7364

Closed
gh3597 opened this issue Jan 19, 2025 · 6 comments
Closed

Vaultwarden version not displayed in admin panel (or anywhere?) #7364

gh3597 opened this issue Jan 19, 2025 · 6 comments

Comments

@gh3597
Copy link

gh3597 commented Jan 19, 2025

Required Information

  • DietPi version | DietPi v9.8.0 (although this issue has been apparent in multiple versions previous to this going back for a couple of years)
  • Distro version | bullseye
  • Kernel version | Linux vaultwarden 5.10.0-33-amd64 #1 SMP Debian 5.10.226-1 (2024-10-03) x86_64 GNU/Linux
  • SBC model | Virtual Machine (x86_64)
  • Power supply used | Not relevant but redundant 960W power supplies!
  • SD card used | Again not relevant but installed on RAID5 array on 4x 1TB WD RED drives

Additional Information (if applicable)

  • Software title | vaultwarden
  • Was the software title installed freshly or updated/migrated? Installed with DietPi using the extra software options.
  • Can this issue be replicated on a fresh installation of DietPi? Yes.

Steps to reproduce

Log in to the admin panel of vaultwarden.
Go to diagnostics
View the blank space where current version should be
Image

Expected behaviour

Vaultwarden version should be displayed.

Actual behaviour

Version is not being populated.

Extra details

I posted this as an issue with vaultwarden but they have passed it back to the packager.

Some info from that discussion. dani-garcia/vaultwarden#4936

if packagers provide the right env variable during compile time it should also work
For example, DietPi could use VW_VERSION="1.32.7 - DietPi Edition"

@MichaIng MichaIng added this to the v9.10 milestone Jan 20, 2025
MichaIng added a commit that referenced this issue Jan 20, 2025
- DietPi-Software | vaultwarden: Our builds will now show the package version within the web UI. Many thanks to @gh3597 for reporting it missing and how to add it: #7364
@MichaIng
Copy link
Owner

Many thanks for reporting. This should add it. I am currently testing builds with the new native GitHub Actions ARM runners. Once this all works, and those builds do indeed show the version in the web UI, I can push the resulting packages to our APT server: 333bd4e

@MichaIng
Copy link
Owner

I just pushed a new build to our APT servers, which should show the version in the web UI.

@gh3597
Copy link
Author

gh3597 commented Feb 15, 2025

Just tested this and it is better but seems that the build is displayed in the current version and the DietPi build differs slightly so it shows there's an update available,but there isn't.

Image

@MichaIng
Copy link
Owner

MichaIng commented Feb 15, 2025

It shows the very latest commit of the main branch: dani-garcia/vaultwarden@3baffee
That is however not released: https://github.com/dani-garcia/vaultwarden/releases
The latest release tag 1.33.2 has the commit 1f868b8. So IMO this information is somewhat misleading, at least if the aim is to show the latest release.

@gh3597
Copy link
Author

gh3597 commented Feb 15, 2025

IMO this information is somewhat misleading, at least if the aim is to show the latest release

That was my thinking too, both bits of info are superfluous here. Just 1.33.2 is all that is required. Defintiely "workable" as it is but a minor annoyance nonetheless. Appreciate this is an issue with the package and not DietPi.

@MichaIng
Copy link
Owner

MichaIng commented Feb 15, 2025

Based on the info here, I replaced the - with a +. But actually you are right, and we could just remove the suffix completely 🤔. It is important for the package version, as we may do a rebuild with same vaultwarden version but different web vault, or something around packaging or config changed. But the vaultwarden source version/binary is not affected by this, so I guess indeed we can just remove the suffix entirely.

EDIT: Done like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants