-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages sizes in appcache: ground_servertime takes 375KB ?? #176
Comments
not sure - the latest ground db is much less code - but it relies on mozillas "localforage". The servertime though... that's like 5 lines of code, |
unless meteor bundles localforage in both bundles... |
If servertime uses localforage too, then Meteor may in fact bundle it in both packages and that would explain the significant size? Have you considered a single package (integrate servertime in ground:db) ?? |
Previously I had a meteor wrapper package for localforage, this would only get included once - but wanted to use the npm module directly. (assumed it would work the same...) If you can prove that localforage is added twice I would consider it a serious issue in the meteor build tool, might be worth opening an issue there or ask in forum.meteor.com. |
I will check if I can find out more, but I am a bit new to NPM and Meteor packages. It seems that Meteor bundles each Meteor package separately in a single file which is compresses and sent to client?? so yes localforage is packaged twice probably?? Maybe to avoid these issues:
I would be happy with 3 since servertime is 5 lines of code?? |
Meteor currently added localforage twice.. #176
Let me know if this is still an issue in 2.0.0-rc.5 |
Did not get a response, so I assume that this was fixed. |
I use Ground:db and it works great for mobile app with offline data. I use react, react-meteor-data and the latest grounddb caching and follow instructions in v2 usage and I get offline data in my mobile app and full reactivity while connected with almost no extra work. Thanks for a great package!
I do notice that my appcache size is quite big (14MB) so I checked which packages take most space:
No issue with ground_db package.js size, but ground_servertime.js? I checked the repositories and I cannot understand why ground_servertime would take so much space? Code seems to be only a few lines?
Versions used:
Appcache size screenshot:
The text was updated successfully, but these errors were encountered: