Skip to content

Commit 83f6182

Browse files
authored
chore: upgrade NDK 26 on bitrise.yml (#13862)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR upgrades NDK version to 26.1.10909125. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 429d3d7 commit 83f6182

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: android/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ buildscript {
88
compileSdkVersion = 34
99
targetSdkVersion = 34
1010
// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
11-
ndkVersion = "24.0.8215888"
11+
ndkVersion = "26.1.10909125"
1212
bitriseNdkPath = "/usr/local/share/android-sdk/ndk-bundle"
1313
kotlin_version = "1.7.22"
1414
kotlinVersion = "$kotlin_version"

Diff for: bitrise.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1798,7 +1798,7 @@ app:
17981798
PROJECT_LOCATION: android
17991799
- opts:
18001800
is_expand: false
1801-
NDK_VERSION: 24.0.8215888
1801+
NDK_VERSION: 26.1.10909125
18021802
- opts:
18031803
is_expand: false
18041804
QA_APK_NAME: app-qa-release

Diff for: docs/readme/environment.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ Install [Android Studio](https://developer.android.com/studio)
101101
- Select `SDK Tools` tab
102102
- Check `Show Package Details` option below the tools list to show available versions
103103
- Locate `NDK (Side-by-side)` option in the tools list
104-
- Check NDK version `24.0.8215888`
104+
- Check NDK version `26.1.10909125`
105105
- Locate `CMake` option in the tools list
106106
- Check CMake version `3.22.1`
107107
- Click "Apply" or "OK" to download

0 commit comments

Comments
 (0)