Skip to content

Commit 19f0686

Browse files
chore: bump detox version to 20.33.0 (#13471)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump detox version to 20.33.0. This required additional changes to the build scripts. ## **Related issues** Fixes: #13321 ## **Manual testing steps** Should continue to be able to run e2e locally. Should continue to be able to run e2e on bitrise. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> See linked issue. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 00dd0f1 commit 19f0686

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ dependencies {
288288
} else {
289289
implementation jscFlavor
290290
}
291-
androidTestImplementation('com.wix:detox-legacy:+') {
291+
androidTestImplementation('com.wix:detox:+') {
292292
exclude module: "protobuf-lite"
293293
}
294294
androidTestImplementation ('androidx.test.espresso:espresso-contrib:3.4.0')

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@
460460
"browserstack-local": "^1.5.1",
461461
"chromedriver": "^123.0.1",
462462
"depcheck": "^1.4.7",
463-
"detox": "^20.27.5",
463+
"detox": "20.33.0",
464464
"dotenv": "^16.0.3",
465465
"dpdm": "^3.14.0",
466466
"enzyme": "3.9.0",

scripts/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ buildAndroidRunE2E(){
571571
then
572572
source $ANDROID_ENV_FILE
573573
fi
574-
cd android && ./gradlew assembleProdDebug app:assembleAndroidTest -DtestBuildType=debug --build-cache --parallel && cd ..
574+
cd android && ./gradlew assembleProdDebug app:assembleAndroidTest -PminSdkVersion=26 -DtestBuildType=debug --build-cache --parallel && cd ..
575575
}
576576

577577
buildIos() {

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15191,23 +15191,23 @@ detect-node@^2.0.4:
1519115191
resolved "https://registry.yarnpkg.com/detect-node/-/detect-node-2.1.0.tgz#c9c70775a49c3d03bc2c06d9a73be550f978f8b1"
1519215192
integrity sha512-T0NIuQpnTvFDATNuHN5roPwSBG83rFsuO+MXXH9/3N1eFbn4wcPjttvjMLEPWJ0RGUYgQE7cGgS3tNxbqCGM7g==
1519315193

15194-
detox-copilot@^0.0.23:
15195-
version "0.0.23"
15196-
resolved "https://registry.yarnpkg.com/detox-copilot/-/detox-copilot-0.0.23.tgz#724aeb62424018b4b6d5620bb0dc7e800e4e4f6b"
15197-
integrity sha512-qDSdLwgPUMVawpE0R3agNWd2U69ilTnhf+SodSqqrkmTI0oG67IfkACvwox+K9Slcc8ki6y0Bw6QVBi54MqpaA==
15194+
detox-copilot@^0.0.27:
15195+
version "0.0.27"
15196+
resolved "https://registry.yarnpkg.com/detox-copilot/-/detox-copilot-0.0.27.tgz#350ee91ae6ba77acac78513ccbda7aafcb3c6faf"
15197+
integrity sha512-H2febTNp0arVx2A8rvM1C2BwDiBEP/2Ya8Hd1mVyV66rR5u8om1gdIypaRGm+plpTLCHhlefe4+7qLtHgVzpng==
1519815198

15199-
detox@^20.27.5:
15200-
version "20.27.5"
15201-
resolved "https://registry.yarnpkg.com/detox/-/detox-20.27.5.tgz#f67d1a0c9ddbb2b6edb838e1b32c63b486be66ea"
15202-
integrity sha512-JBe3fONwaSxYubd/36SZh3c2MaYs+Cx7sOA4GJfh16QTyoB7XvvbGrSlQDTbag/f0j5RZt4judPtg5A3P1/Uhg==
15199+
detox@20.33.0:
15200+
version "20.33.0"
15201+
resolved "https://registry.yarnpkg.com/detox/-/detox-20.33.0.tgz#5a032b0ef2987294e741d10e91600a532e253a3a"
15202+
integrity sha512-9KZC3NgCav/IvuWm/EaKNIL5lV2bJf23PPK67OHS2dMhJsDsNBRWP9k3RN7hzLzzUwAXMMoOmk+S1OpOsazNFA==
1520315203
dependencies:
1520415204
ajv "^8.6.3"
1520515205
bunyan "^1.8.12"
1520615206
bunyan-debug-stream "^3.1.0"
1520715207
caf "^15.0.1"
1520815208
chalk "^4.0.0"
1520915209
child-process-promise "^2.2.0"
15210-
detox-copilot "^0.0.23"
15210+
detox-copilot "^0.0.27"
1521115211
execa "^5.1.1"
1521215212
find-up "^5.0.0"
1521315213
fs-extra "^11.0.0"

0 commit comments

Comments
 (0)