Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Connect - Queuing connect requests from different dapps causes to display all domains as the first domain that made the request #29594

Open
seaona opened this issue Jan 9, 2025 · 2 comments
Labels
regression-RC-12.10.0 Regression bug that was found in release candidate (RC) for release 12.10.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team team-wallet-api-platform type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Jan 9, 2025

Describe the bug

Queuing connect requests from different dapps causes to display all domains as the first domain that made the request.

Note that in current production 12.9.3, the requests are not queued, so the issue is not present there.

Expected behavior

Display the correct domain for each request

Screenshots/Recordings

connect-incorrect-domain.mp4

Steps to reproduce

  1. Open one browser tab and go to a dapp ie https://metamask.github.io/test-dapp/
  2. Open another browser tab and go to Uniswap https://app.uniswap.org/swap
  3. Click Connect to the test dapp
  4. Without accepting or rejecting, go to Uniswap
  5. Click Connect to Uniswap
  6. Navigate to both requests and see how both domains display the test-dapp one
  7. Cancel the first request, the one coming from the test dapp
  8. See how the second request still displays the incorrect domain (test dapp) instead of uniswap

Error messages or log output

Detection stage

During release testing

Version

12.10.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added regression-RC-12.10.0 Regression bug that was found in release candidate (RC) for release 12.10.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. type-bug labels Jan 9, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 9, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 9, 2025
@seaona
Copy link
Contributor Author

seaona commented Jan 9, 2025

Note: I added the sev1 label since this seems like a security issue, but feel free to re-assess if needed @adonesky1 🙏

@adonesky1
Copy link
Contributor

I believe the issue is introduced by this commit, this PR, which makes some updates to the confirmation navigation system

@adonesky1 adonesky1 added the team-confirmations Push issues to confirmations team label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.10.0 Regression bug that was found in release candidate (RC) for release 12.10.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-confirmations Push issues to confirmations team team-wallet-api-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

2 participants