diff --git a/test/e2e/page-objects/pages/settings/security-and-privacy-settings.ts b/test/e2e/page-objects/pages/settings/security-and-privacy-settings.ts index b24b02316dec..4d0b7b48e130 100644 --- a/test/e2e/page-objects/pages/settings/security-and-privacy-settings.ts +++ b/test/e2e/page-objects/pages/settings/security-and-privacy-settings.ts @@ -5,10 +5,8 @@ import SettingsPage from './settings-page'; class SecurityAndPrivacySettings { private readonly driver: Driver; - private readonly securityAndPrivacySettingsPageTitle = { - text: 'Security & privacy', - tag: 'h4', - }; + private readonly securityAndPrivacySettingsPageBodySection = + '[data-testid="settings-page-body-section"]'; private readonly participateInMetaMetricsToggle = '[data-testid="participate-in-meta-metrics-toggle"] .toggle-button'; @@ -23,7 +21,7 @@ class SecurityAndPrivacySettings { async check_pageIsLoaded(): Promise { try { await this.driver.waitForSelector( - this.securityAndPrivacySettingsPageTitle, + this.securityAndPrivacySettingsPageBodySection, ); } catch (e) { console.log( @@ -41,7 +39,6 @@ class SecurityAndPrivacySettings { const settingsPage = new SettingsPage(this.driver); await settingsPage.check_pageIsLoaded(); await settingsPage.goToPrivacySettings(); - await this.check_pageIsLoaded(); } async toggleParticipateInMetaMetrics(): Promise { diff --git a/test/e2e/page-objects/pages/settings/settings-page.ts b/test/e2e/page-objects/pages/settings/settings-page.ts index 4444556a1b74..f73fc258707e 100644 --- a/test/e2e/page-objects/pages/settings/settings-page.ts +++ b/test/e2e/page-objects/pages/settings/settings-page.ts @@ -6,20 +6,14 @@ class SettingsPage { private readonly closeSettingsPageButton = '.settings-page__header__title-container__close-button'; - private readonly developerOptionsButton = { - text: 'Developer Options', - css: '.tab-bar__tab__content__title', - }; + private readonly developerOptionsButton = + '[data-testid="tab-content-Developer Options"]'; - private readonly experimentalSettingsButton = { - text: 'Experimental', - css: '.tab-bar__tab__content__title', - }; + private readonly experimentalSettingsButton = + '[data-testid="tab-content-Experimental"]'; - private readonly privacySettingsButton = { - text: 'Security & privacy', - css: '.tab-bar__tab__content__title', - }; + private readonly privacySettingsButton = + '[data-testid="tab-content-Security & privacy"]'; private readonly settingsPageTitle = { text: 'Settings', diff --git a/test/e2e/tests/metrics/segment-user-traits.spec.ts b/test/e2e/tests/metrics/segment-user-traits.spec.ts index b92468529e19..19490d5dc695 100644 --- a/test/e2e/tests/metrics/segment-user-traits.spec.ts +++ b/test/e2e/tests/metrics/segment-user-traits.spec.ts @@ -123,6 +123,7 @@ describe('Segment User Traits', function () { driver, ); await securityAndPrivacySettings.navigateToPage(); + await securityAndPrivacySettings.check_pageIsLoaded(); await securityAndPrivacySettings.toggleParticipateInMetaMetrics(); events = await getEventPayloads(driver, mockedEndpoints); assert.equal(events.length, 1); @@ -156,6 +157,7 @@ describe('Segment User Traits', function () { driver, ); await securityAndPrivacySettings.navigateToPage(); + await securityAndPrivacySettings.check_pageIsLoaded(); await securityAndPrivacySettings.toggleParticipateInMetaMetrics(); await securityAndPrivacySettings.toggleDataCollectionForMarketing(); events = await getEventPayloads(driver, mockedEndpoints); @@ -166,12 +168,13 @@ describe('Segment User Traits', function () { ); }); - it('should stop sending identify events when user disables metrics in privacy settings after opting in during onboarding', async function () { + it.only('should stop sending identify events when user disables metrics in privacy settings after opting in during onboarding', async function () { await withFixtures( { fixtures: new FixtureBuilder({ onboarding: true }) .withMetaMetricsController({ metaMetricsId: MOCK_META_METRICS_ID, + participateInMetaMetrics: true, }) .build(), title: this.test?.fullTitle(), @@ -190,6 +193,7 @@ describe('Segment User Traits', function () { driver, ); await securityAndPrivacySettings.navigateToPage(); + await securityAndPrivacySettings.check_pageIsLoaded(); await securityAndPrivacySettings.toggleParticipateInMetaMetrics(); events = await getEventPayloads(driver, mockedEndpoints); assert.equal(events.length, 1); diff --git a/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap b/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap index deb95bd48555..13caa0c5dc82 100644 --- a/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap +++ b/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap @@ -172,7 +172,7 @@ exports[`SnapUIAddress renders Ethereum address 1`] = ` { )}
{icon}
-
{content}
+
+ {content} +
+
{this.renderUseExternalServices()} {showDataCollectionDisclaimer ? this.renderDataCollectionWarning()