Skip to content

Commit d2d1800

Browse files
ccharlyCal-L
andauthored
fix: fix peer deps for @metamask/{accounts,multichain-network}-controller (#5327)
## Explanation The 2 controllers depend on each other, however we cannot really express this with peer deps. So for now, we only declare this "relation" on the new controller `mutltichain-network-controller`. Also downgrading some peer dep to use the major version. ## References N/A ## Changelog N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Cal-L <[email protected]>
1 parent fe244b1 commit d2d1800

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

packages/accounts-controller/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
"@metamask/eth-snap-keyring": "^10.0.0",
5353
"@metamask/keyring-api": "^17.0.0",
5454
"@metamask/keyring-internal-api": "^4.0.1",
55+
"@metamask/network-controller": "^22.2.1",
5556
"@metamask/snaps-sdk": "^6.17.1",
5657
"@metamask/snaps-utils": "^8.10.0",
5758
"@metamask/utils": "^11.1.0",
@@ -63,7 +64,6 @@
6364
"devDependencies": {
6465
"@metamask/auto-changelog": "^3.4.4",
6566
"@metamask/keyring-controller": "^19.1.0",
66-
"@metamask/network-controller": "^22.2.1",
6767
"@metamask/providers": "^18.1.1",
6868
"@metamask/snaps-controllers": "^9.19.0",
6969
"@types/jest": "^27.4.1",
@@ -76,8 +76,8 @@
7676
"webextension-polyfill": "^0.12.0"
7777
},
7878
"peerDependencies": {
79-
"@metamask/keyring-controller": "^19.1.0",
80-
"@metamask/network-controller": "^22.2.1",
79+
"@metamask/keyring-controller": "^19.0.0",
80+
"@metamask/network-controller": "^22.0.0",
8181
"@metamask/providers": "^18.1.0",
8282
"@metamask/snaps-controllers": "^9.19.0",
8383
"webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0"

packages/multichain-network-controller/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@
6868
"typescript": "~5.2.2"
6969
},
7070
"peerDependencies": {
71-
"@metamask/network-controller": "^22.2.1"
71+
"@metamask/accounts-controller": "^23.0.0",
72+
"@metamask/network-controller": "^22.0.0"
7273
},
7374
"engines": {
7475
"node": "^18.18 || >=20"

yarn.lock

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2370,8 +2370,8 @@ __metadata:
23702370
uuid: "npm:^8.3.2"
23712371
webextension-polyfill: "npm:^0.12.0"
23722372
peerDependencies:
2373-
"@metamask/keyring-controller": ^19.1.0
2374-
"@metamask/network-controller": ^22.2.1
2373+
"@metamask/keyring-controller": ^19.0.0
2374+
"@metamask/network-controller": ^22.0.0
23752375
"@metamask/providers": ^18.1.0
23762376
"@metamask/snaps-controllers": ^9.19.0
23772377
webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0
@@ -3475,7 +3475,8 @@ __metadata:
34753475
typedoc-plugin-missing-exports: "npm:^2.0.0"
34763476
typescript: "npm:~5.2.2"
34773477
peerDependencies:
3478-
"@metamask/network-controller": ^22.2.1
3478+
"@metamask/accounts-controller": ^23.0.0
3479+
"@metamask/network-controller": ^22.0.0
34793480
languageName: unknown
34803481
linkType: soft
34813482

0 commit comments

Comments
 (0)