Skip to content

Commit a3e603c

Browse files
feat: add destinationChainId to support cross chain txs (#4988)
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR adds a new field to the `TransactionMeta` type to facilitate Bridge transactions. The primary purpose is to ensure that `destinationTokenAddress` refers to the correct token on the correct chain. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> A slimmed down version of #4918 Related to MetaMask/metamask-extension#28460 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` - **ADDED**: `destinationChainId` to the `TransactionMeta` type ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
1 parent 923f0e4 commit a3e603c

File tree

1 file changed

+5
-0
lines changed
  • packages/transaction-controller/src

1 file changed

+5
-0
lines changed

packages/transaction-controller/src/types.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,11 @@ type TransactionMetaBase = {
121121
*/
122122
deviceConfirmedOn?: WalletDevice;
123123

124+
/**
125+
* The Network ID as per EIP-155 of the destination chain of a bridge transaction.
126+
*/
127+
destinationChainId?: Hex;
128+
124129
/**
125130
* The address of the token being received of swap transaction.
126131
*/

0 commit comments

Comments
 (0)