Skip to content

Commit b405a4e

Browse files
committed
chore(kyring-eth-ledger-bridge): add more comments
1 parent f916f75 commit b405a4e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/keyring-eth-ledger-bridge/src/ledger-keyring.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@ export class LedgerKeyring extends EventEmitter {
123123
return this.bridge.destroy();
124124
}
125125

126-
async serialize(): Promise<Partial<LedgerBridgeKeyringOptions>> {
126+
async serialize(): Promise<
127+
Partial<LedgerBridgeKeyringOptions> // Maybe we should have a proper "state" type here instead of using this "options" type.
128+
> {
127129
return {
128130
hdPath: this.hdPath,
129131
accounts: this.accounts,
@@ -134,7 +136,7 @@ export class LedgerKeyring extends EventEmitter {
134136
}
135137

136138
async deserialize(
137-
opts: Partial<LedgerBridgeKeyringOptions> = {},
139+
opts: Partial<LedgerBridgeKeyringOptions> = {}, // Same question here?
138140
): Promise<void> {
139141
this.hdPath = opts.hdPath ?? hdPathString;
140142
this.accounts = opts.accounts ?? [];

0 commit comments

Comments
 (0)