refactor(keyring-eth-ledger-bridge): fix new eslint errors

Author: ccharly

packages/keyring-eth-ledger-bridge/src/index.ts

@@ -1,7 +1,7 @@
 export * from './ledger-keyring';
 export * from './ledger-iframe-bridge';
 export * from './ledger-mobile-bridge';
-export * from './ledger-bridge';
+export type * from './ledger-bridge';
 export * from './ledger-transport-middleware';
-export * from './type';
+export type * from './type';
 export * from './ledger-hw-app';

packages/keyring-eth-ledger-bridge/src/ledger-hw-app.ts

@@ -1,16 +1,8 @@
 import LedgerHwAppEth from '@ledgerhq/hw-app-eth';
-// eslint-disable-next-line import/no-nodejs-modules
 import { Buffer } from 'buffer';
 
 import { GetAppNameAndVersionResponse } from './type';
 
-// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
-export interface MetaMaskLedgerHwAppEth extends LedgerHwAppEth {
-  openEthApp(): void;
-  closeApps(): void;
-  getAppNameAndVersion(): Promise<GetAppNameAndVersionResponse>;
-}
-
 export class MetaMaskLedgerHwAppEth
   extends LedgerHwAppEth
   implements MetaMaskLedgerHwAppEth

packages/keyring-eth-ledger-bridge/src/ledger-iframe-bridge.test.ts

@@ -51,7 +51,7 @@ describe('LedgerIframeBridge', function () {
   function stubKeyringIFramePostMessage(
     bridgeInstance: LedgerIframeBridge,
     fn: (message: IFrameMessageResponse) => void,
-  ) {
+  ): void {
     if (!isIFrameValid(bridgeInstance.iframe)) {
       throw new Error('the iframe is not valid');
     }

packages/keyring-eth-ledger-bridge/src/ledger-iframe-bridge.ts

@@ -96,7 +96,7 @@ export class LedgerIframeBridge
 
   iframeLoaded = false;
 
-  #opts: LedgerIframeBridgeOptions;
+  readonly #opts: LedgerIframeBridgeOptions;
 
   eventListener?: (eventMessage: {
     origin: string;
@@ -121,15 +121,15 @@ export class LedgerIframeBridge
     };
   }
 
-  async init() {
+  async init(): Promise<void> {
     await this.#setupIframe(this.#opts.bridgeUrl);
 
     this.eventListener = this.#eventListener.bind(this, this.#opts.bridgeUrl);
 
     window.addEventListener('message', this.eventListener);
   }
 
-  async destroy() {
+  async destroy(): Promise<void> {
     if (this.eventListener) {
       window.removeEventListener('message', this.eventListener);
     }
@@ -158,7 +158,8 @@ export class LedgerIframeBridge
           if ('success' in response && response.success) {
             resolve(true);
           } else if ('error' in response) {
-            reject(response.error);
+            // Assuming this is using an `Error` type:
+            reject(response.error as Error);
           } else {
             reject(new Error('Unknown error occurred'));
           }
@@ -249,7 +250,12 @@ export class LedgerIframeBridge
       | [IFrameMessageAction.LedgerSignTransaction, LedgerSignTransactionParams]
       | [IFrameMessageAction.LedgerSignPersonalMessage, LedgerSignMessageParams]
       | [IFrameMessageAction.LedgerSignTypedData, LedgerSignTypedDataParams]
-  ) {
+  ): Promise<
+    | GetPublicKeyResponse
+    | LedgerSignTransactionResponse
+    | LedgerSignMessageResponse
+    | LedgerSignTypedDataResponse
+  > {
     return new Promise((resolve, reject) => {
       this.#sendMessage(
         {
@@ -276,15 +282,15 @@ export class LedgerIframeBridge
       this.iframe = document.createElement('iframe');
       this.iframe.src = bridgeUrl;
       this.iframe.allow = `hid 'src'`;
-      this.iframe.onload = async () => {
+      this.iframe.onload = async (): Promise<void> => {
         this.iframeLoaded = true;
         resolve();
       };
       document.head.appendChild(this.iframe);
     });
   }
 
-  #getOrigin(bridgeUrl: string) {
+  #getOrigin(bridgeUrl: string): string {
     const tmp = bridgeUrl.split('/');
     tmp.splice(-1, 1);
     return tmp.join('/');
@@ -296,7 +302,7 @@ export class LedgerIframeBridge
       origin: string;
       data: IFrameMessageResponse;
     },
-  ) {
+  ): void {
     if (eventMessage.origin !== this.#getOrigin(bridgeUrl)) {
       return;
     }
@@ -317,7 +323,7 @@ export class LedgerIframeBridge
   #sendMessage<TAction extends IFrameMessageAction>(
     message: IFrameMessage<TAction>,
     callback: (response: IFrameMessageResponse) => void,
-  ) {
+  ): void {
     this.currentMessageId += 1;
 
     const postMsg: IFramePostMessage<TAction> = {
@@ -328,7 +334,7 @@ export class LedgerIframeBridge
 
     this.messageCallbacks[this.currentMessageId] = callback;
 
-    if (!this.iframeLoaded || !this.iframe || !this.iframe.contentWindow) {
+    if (!this.iframeLoaded || !this.iframe?.contentWindow) {
       throw new Error('The iframe is not loaded yet');
     }
 

packages/keyring-eth-ledger-bridge/src/ledger-keyring.test.ts

@@ -93,7 +93,7 @@ describe('LedgerKeyring', function () {
    * @param accountIndex - The index of the account to unlock.
    * @returns Returns a promise that resolves when the keyring is unlocked.
    */
-  async function basicSetupToUnlockOneAccount(accountIndex = 0) {
+  async function basicSetupToUnlockOneAccount(accountIndex = 0): Promise<void> {
     keyring.setAccountToUnlock(accountIndex);
     await keyring.addAccounts();
     jest