Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalStateException: SkinsRestorer API is not initialized yet! #57

Open
NicoNekoDev opened this issue Feb 9, 2025 · 7 comments
Open
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@NicoNekoDev
Copy link

SkinRestorerAPI is not initialized as is runs in "proxy mode" so this is why the error.
https://skinsrestorer.net/docs/development/api#when-using-bungeecordvelocity

https://mclo.gs/IRHyGLN

I'm using the (currently last) commit 538d281.

@Matt-MX
Copy link
Owner

Matt-MX commented Feb 13, 2025

I didn't plan to support cracked servers using this plugin and won't fix it, but @kxtsoo or anyone else can submit a PR to do so, and I will happily review it and probably merge it!

Hope you understand.

@Matt-MX Matt-MX added bug Something isn't working wontfix This will not be worked on labels Feb 13, 2025
@kxtsoo
Copy link
Contributor

kxtsoo commented Feb 13, 2025

Hey. The SkinRestorerAPI is littlebit weird if you use proxy mode (i turned off D:) but if you really wan't i can to find a solution and fix that (at this moment idk how prob need a api jar)

@NicoNekoDev
Copy link
Author

I'm not even sure why this plugin needs to hook into SkinRestorer ngl, I just reported an error showed in the Console, related to the SkinRestorer being on proxy mode and the API not being available. 🤷🏻‍♂️ I could change from proxy side mode to server side mode, but players that change their skins on one server, will have to do it on others servers too, and it will not sync across servers.
@Matt-MX SkinRestorer isn't only for cracked servers, it's a plugin to change players skins for premium servers too.

@kxtsoo
Copy link
Contributor

kxtsoo commented Feb 14, 2025

I'm not even sure why this plugin needs to hook into SkinRestorer ngl, I just reported an error showed in the Console, related to the SkinRestorer being on proxy mode and the API not being available. 🤷🏻‍♂️ I could change from proxy side mode to server side mode, but players that change their skins on one server, will have to do it on others servers too, and it will not sync across servers. @Matt-MX SkinRestorer isn't only for cracked servers, it's a plugin to change players skins for premium servers too.

You say you not event want to use SkinRestorer in DisplayNametags but the plugins needs? I can fix that and give option to fully disable the SkinRestorer functions in DisplayNametags

@NicoNekoDev
Copy link
Author

I'm not even sure why this plugin needs to hook into SkinRestorer ngl, I just reported an error showed in the Console, related to the SkinRestorer being on proxy mode and the API not being available. 🤷🏻‍♂️ I could change from proxy side mode to server side mode, but players that change their skins on one server, will have to do it on others servers too, and it will not sync across servers. @Matt-MX SkinRestorer isn't only for cracked servers, it's a plugin to change players skins for premium servers too.

You say you not event want to use SkinRestorer in DisplayNametags but the plugins needs? I can fix that and give option to fully disable the SkinRestorer functions in DisplayNametags

I'm just asking, why does the plugin hooks into SkinsRestorer? Is any reason for that? And if there is a reason, then it should be fixed, not just added an option to fully disable the SkinsRestorer functions.

@kxtsoo
Copy link
Contributor

kxtsoo commented Feb 15, 2025

I'm not even sure why this plugin needs to hook into SkinRestorer ngl, I just reported an error showed in the Console, related to the SkinRestorer being on proxy mode and the API not being available. 🤷🏻‍♂️ I could change from proxy side mode to server side mode, but players that change their skins on one server, will have to do it on others servers too, and it will not sync across servers. @Matt-MX SkinRestorer isn't only for cracked servers, it's a plugin to change players skins for premium servers too.

You say you not event want to use SkinRestorer in DisplayNametags but the plugins needs? I can fix that and give option to fully disable the SkinRestorer functions in DisplayNametags

I'm just asking, why does the plugin hooks into SkinsRestorer? Is any reason for that? And if there is a reason, then it should be fixed, not just added an option to fully disable the SkinsRestorer functions.

The SkinRestorer hook update your nametag. When you change skin your nametag is just pop off and not follow you (if you have show-self config on true) This is why i added that, now if you change skin you got a message to rejoin + your nametag (only for just you) will disabled and fixed if you rejoin.

@NicoNekoDev
Copy link
Author

Oh I see, then it's better if this gets fixed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants