Merge pull request #32320 from ptravers/pt/9230

refactor reductionmonoid prevent clone of row on clone_from

Author: ptravers

src/compute/src/render/reduce.rs

@@ -2321,7 +2321,7 @@ mod monoids {
     use serde::{Deserialize, Serialize};
 
     /// A monoid containing a single-datum row.
-    #[derive(Ord, PartialOrd, Eq, PartialEq, Debug, Clone, Serialize, Deserialize, Hash)]
+    #[derive(Ord, PartialOrd, Eq, PartialEq, Debug, Serialize, Deserialize, Hash)]
     pub enum ReductionMonoid {
         Min(Row),
         Max(Row),
@@ -2336,6 +2336,35 @@ mod monoids {
         }
     }
 
+    impl Clone for ReductionMonoid {
+        fn clone(&self) -> Self {
+            use ReductionMonoid::*;
+            match self {
+                Min(row) => Min(row.clone()),
+                Max(row) => Max(row.clone()),
+            }
+        }
+
+        fn clone_from(&mut self, source: &Self) {
+            use ReductionMonoid::*;
+
+            let mut row = std::mem::take(match self {
+                Min(row) | Max(row) => row,
+            });
+
+            let source_row = match source {
+                Min(row) | Max(row) => row,
+            };
+
+            row.clone_from(source_row);
+
+            match source {
+                Min(_) => *self = Min(row),
+                Max(_) => *self = Max(row),
+            }
+        }
+    }
+
     impl Multiply<Diff> for ReductionMonoid {
         type Output = Self;