Skip to content

Commit bcc2e1e

Browse files
committed
Bump Rust version to 1.67
This requires us to silence a new clippy lint, `clippy::unchecked_duration_subtraction`. While the lint triggering is not an FP, it is not very helpful either in this case. Substracting a small tick duration from the current time will never underflow, and if it did we probably would like to panic anyway. Note that the lint seems to be "allow by default" on the current clippy main, so we should be able to remove the explicit #[allow] again in the future.
1 parent b9a16b3 commit bcc2e1e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ resolver = "2"
7373

7474
[workspace.package]
7575
edition = "2021"
76-
rust-version = "1.66.0"
76+
rust-version = "1.67.0"
7777

7878
[profile.dev]
7979
# TODO(gusywnn|benesch): remove this when incremental ice's are improved

src/storage/src/source/generator.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ impl SourceConnectionBuilder for LoadGeneratorSourceConnection {
121121
LoadGeneratorSourceReader {
122122
rows: Box::new(rows),
123123
// Subtract tick so we immediately produce a row.
124+
#[allow(clippy::unchecked_duration_subtraction)]
124125
last: Instant::now() - tick,
125126
tick,
126127
offset,

0 commit comments

Comments
 (0)