Skip to content

Commit a29775e

Browse files
committed
mzbench: remove
mzbench has been obsoleted by the feature benchmark framework (in test/feature-benchmark) and the cloudbench tool (bin/cloudbench). The kafka-avro-generator tool has been obsoleted by parallelizing kgen directly (#9841). So this commit removes mzbench. To expound on the rational for removing mzbench: * mzbench configurations require an unmaintainable duplication of mzcompose.yml files. Each mzbench configuration contains 300+ lines of nearly identical definitions. There was talk of improving this (see #6676), but the plans never came to fruition. * The interplay between mzbench and mzcompose is unnecessarily delicate. mzbench expects a composition with workflows named just so, and then parses their output. This makes it very difficult to refactor the underlying compositions, since you don't know if you're breaking the contract with mzbench. I think most of mzbench's features could be recreated much more simply with an e.g. `--num-trials` parameter to mzcompose. * mzbench introduced quite a bit of complexity by trying to be both a demo of using Materialize to power a real-time dashboard [0] and a benchmarking framework. Experience suggests that this results in a tool that is a suboptimal dashboard and a suboptimal benchmarking framework. Better to have two separate tools optimized for their specific purpose. The new feature benchmarking framework resolves the above concerns. It is only focused on being a benchmarking framework and does not suffer from the code duplication problem. [0]: https://github.com/MaterializeInc/materialize/blob/45586f38a/doc/developer/mzbench.md#worker-balance-visualization
1 parent 45586f3 commit a29775e

File tree

98 files changed

+0
-5835
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+0
-5835
lines changed

bin/mzbench

Lines changed: 0 additions & 14 deletions
This file was deleted.

ci/test/pipeline.template.yml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -162,30 +162,6 @@ steps:
162162
run: ci
163163
timeout_in_minutes: 30
164164

165-
- label: "aggregations benchmark sanity check"
166-
depends_on: build-x86_64
167-
plugins:
168-
- ./ci/plugins/mzcompose:
169-
composition: aggregations
170-
run: ci
171-
timeout_in_minutes: 10
172-
173-
- label: "avro upsert benchmark sanity check"
174-
depends_on: build-x86_64
175-
plugins:
176-
- ./ci/plugins/mzcompose:
177-
composition: avro-upsert
178-
run: ci
179-
timeout_in_minutes: 10
180-
181-
- label: "kafka sink (avro debezium) benchmark sanity check"
182-
depends_on: build-x86_64
183-
plugins:
184-
- ./ci/plugins/mzcompose:
185-
composition: kafka-sink-avro-debezium
186-
run: ci
187-
timeout_in_minutes: 10
188-
189165
- label: ":book: catalog compatibility check"
190166
depends_on: build-x86_64
191167
timeout_in_minutes: 30

doc/developer/mzbench.md

Lines changed: 0 additions & 126 deletions
This file was deleted.

misc/perf-dash/app/Dockerfile

Lines changed: 0 additions & 20 deletions
This file was deleted.

misc/perf-dash/app/mzbuild.yml

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)