Force frame pointers in Rust code

Author: teskje

.bazelrc

@@ -144,6 +144,10 @@ build --@rules_rust//:extra_rustc_flag="-Ccodegen-units=64"
 # just `.rmeta` instead of the full `.rlib`.
 build --@rules_rust//rust/settings:pipelined_compilation=True
 
+# Enforce frame pointers everywhere. We rely on them for collecting backtraces.
+build --@rules_rust//:extra_rustc_flag="-Cforce-frame-pointers=yes"
+build --copt=-fno-omit-frame-pointer
+
 # `cargo check` like config, still experimental!
 #
 # Ignores all outputs other than `.rmeta`, requires pipelied_compilation to be enabled!

.cargo/config.toml

@@ -17,6 +17,7 @@ rustflags = [
     "-Clink-arg=-Wl,-O3",
     "-Clink-arg=-fuse-ld=lld",
     "-Csymbol-mangling-version=v0",
+    "-Cforce-frame-pointers=yes",
     "--cfg=tokio_unstable",
 ]
 
@@ -34,6 +35,7 @@ rustflags = [
     "-Clink-arg=-Wl,-O3",
     "-Clink-arg=-fuse-ld=lld",
     "-Csymbol-mangling-version=v0",
+    "-Cforce-frame-pointers=yes",
     "--cfg=tokio_unstable",
 ]
 

ci/builder/Dockerfile

@@ -414,7 +414,7 @@ ENV CC=$ARCH_GCC-unknown-linux-gnu-cc
 ENV CXX=$ARCH_GCC-unknown-linux-gnu-c++
 ENV CXXSTDLIB=static=stdc++
 ENV LDFLAGS="-fuse-ld=lld -static-libstdc++"
-ENV RUSTFLAGS="-Clink-arg=-Wl,--compress-debug-sections=zlib -Clink-arg=-Wl,-O3 -Clink-arg=-fuse-ld=lld -L/opt/x-tools/$ARCH_GCC-unknown-linux-gnu/$ARCH_GCC-unknown-linux-gnu/sysroot/lib/ -Csymbol-mangling-version=v0 --cfg=tokio_unstable"
+ENV RUSTFLAGS="-Clink-arg=-Wl,--compress-debug-sections=zlib -Clink-arg=-Wl,-O3 -Clink-arg=-fuse-ld=lld -L/opt/x-tools/$ARCH_GCC-unknown-linux-gnu/$ARCH_GCC-unknown-linux-gnu/sysroot/lib/ -Csymbol-mangling-version=v0 -Cforce-frame-pointers=yes --cfg=tokio_unstable"
 ENV TARGET_AR=$AR
 ENV TARGET_CC=$CC
 ENV TARGET_CXX=$CXX

misc/python/materialize/xcompile.py

@@ -153,6 +153,7 @@ def cargo(
         "-Clink-arg=-Wl,--compress-debug-sections=zlib",
         "-Clink-arg=-Wl,-O3",
         "-Csymbol-mangling-version=v0",
+        "-Cforce-frame-pointers=yes",
         "--cfg=tokio_unstable",
     ]