Merge pull request #547 from MasoniteFramework/fix/544

added list defaults when using [] in inputs

Author: josephmancuso

src/masonite/input/InputBag.py

@@ -99,6 +99,9 @@ def parse(self, environ):
                     )
 
     def get(self, name, default=None, clean=True, quote=True):
+        if isinstance(name, str) and name.endswith("[]"):
+            default = []
+
         input = data_get(self.all(), name, default)
 
         if isinstance(input, (str,)):

tests/core/request/test_input.py

@@ -45,6 +45,13 @@ def test_all_with_values(self):
         """
         self.assertEqual(bag.all_as_values(), {"hello": "you"})
 
+    def test_can_get_defaults(self):
+        bag = InputBag()
+        bag.load({"QUERY_STRING": ""})
+        self.assertEqual(bag.get("hello", "default"), "default")
+        self.assertEqual(bag.get("hello"), None) #TODO: This should probably return a blank string instead of None
+        self.assertEqual(bag.get("hello[]"), []) 
+
     def test_all_without_internal_values(self):
         bag = InputBag()
         bag.load({"QUERY_STRING": "hello=you&__token=tok"})

tests/features/scheduling/test_scheduling.py

@@ -1,5 +1,5 @@
 import pendulum
-from masonite.tests import TestCase
+from src.masonite.tests import TestCase
 from src.masonite.scheduling import Task
 
 

tests/integrations/tasks/TaskTest.py

@@ -1,5 +1,5 @@
 """Task Module Description"""
-from masonite.scheduling import Task
+from src.masonite.scheduling import Task
 
 
 class TaskTest(Task):