Skip to content

Unable to use "pretty" tests #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denzp opened this issue Apr 24, 2018 · 1 comment
Closed

Unable to use "pretty" tests #111

denzp opened this issue Apr 24, 2018 · 1 comment

Comments

@denzp
Copy link
Contributor

denzp commented Apr 24, 2018

Tests with Mode::Pretty aren't currently working because:

error: pretty-printing failed in round 0 revision None
status: exit code: 101
command: "rustc" "-" "-Zunstable-options" "--unpretty" "expanded" "--target" "x86_64-unknown-linux-gnu" "-L" "/tmp/target-attr.stage-id.pretty.aux" "-L" "crate=../target/debug/" "-L" "dependency=../target/debug/deps/"

stdout:
------------------------------------------
------------------------------------------

stderr:
------------------------------------------
error: Unrecognized option: 'unpretty'
------------------------------------------

It caused by changes in Rust #47440.
Instead of -Zunstable-options --unpretty TYPE we need to use -Z unpretty=TYPE.

Should it be enough just to propagate the changes here?

@laumann
Copy link
Collaborator

laumann commented Apr 25, 2018

Hi! Thanks for reporting this. Yeah, usually just propagating the changes should work.

In this case, it might make sense to also extend the test-project with a pretty mode test, so ensure it keeps working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants