-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Open
Labels
enhancementAdditions and improvements in generalAdditions and improvements in generalhelp wantedWe would appreciate help on this issue/PRWe would appreciate help on this issue/PR
Description
pydub is no longer actively maintained, and is now running into issues with audioop being removed in python 3.13. As such, we should try to remove it from our dependencies and implement the needed features ourselves.
From a quick look through the code, the main features needed to implement are:
AudioSegment.silentAudioSegment.overlayAudioSegment.from_file
manim/manim/scene/scene_file_writer.py
Lines 330 to 334 in ce1fff6
| self.audio_segment = segment.overlay( | |
| new_segment, | |
| position=int(1000 * time), | |
| gain_during_overlay=gain_to_background, | |
| ) |
manim/manim/scene/scene_file_writer.py
Line 327 in ce1fff6
| AudioSegment.silent(int(np.ceil(diff * 1000))), |
manim/manim/scene/scene_file_writer.py
Line 370 in ce1fff6
| new_segment = AudioSegment.from_file(wav_file_path.name) |
alexandrefch
Metadata
Metadata
Assignees
Labels
enhancementAdditions and improvements in generalAdditions and improvements in generalhelp wantedWe would appreciate help on this issue/PRWe would appreciate help on this issue/PR
Type
Projects
Status
🆕 New