-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Open
Labels
enhancementAdditions and improvements in generalAdditions and improvements in generalpr:bugfixBug fix for use in PRs solving a specific issue:bugBug fix for use in PRs solving a specific issue:bug
Description
Enhancement proposal
GrowArrow()
only works for class Arrow
, not for Arrow3D
since it utilizes the own scale
method of Arrow
. This scale
method relies on Arrow
being a TipableVMobject
, which Arrow3D
is not. I have 3 suggestions:
- Do nothing and state that
GrowArrow
is only meant forArrow
. Then I would implement an error when a classArrow3D
is passed. - Implement the changes I proposed in PR Fixing
GrowArrow()
#1668, that is, if anArrow3D
is passed just use the normalscale
. This still looks good. - Build an own
scale
method forArrow3D
. This seems quite time-consuming since one would have to think about implementing thetipable
stuff for 3D Mobjects. This might be good in the future but would be too much for me to handle right now.
Thoughts are welcome!
Additional comments
Metadata
Metadata
Assignees
Labels
enhancementAdditions and improvements in generalAdditions and improvements in generalpr:bugfixBug fix for use in PRs solving a specific issue:bugBug fix for use in PRs solving a specific issue:bug
Type
Projects
Status
🆕 New