Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[✅ test] 테스트 간소화 #160

Open
3 of 8 tasks
shin-mallang opened this issue Dec 12, 2023 · 1 comment
Open
3 of 8 tasks

[✅ test] 테스트 간소화 #160

shin-mallang opened this issue Dec 12, 2023 · 1 comment
Labels
✅ 테스트 🐌 나중에

Comments

@shin-mallang
Copy link
Member

shin-mallang commented Dec 12, 2023 •
edited
Loading

✅ 할 일

  • Service Layer 통합테스트 -> 단위테스트로 변경
  • repository -> JPA Test
  • Controller -> 하지 않음
  • RestAssured 를 통한 인수 + 통합 테스트 수행
  • 인수테스트 source set 분리 후, 인수테스트 제외하고 병렬 실행으로 성능 향상
  • expected는 then 절에
  • 테스트코드는 오류가 발생한 경우에만 작성. jacoco test coverage 변경
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] refactor: dao 에 repository 에노테이션 붙임
f9e59ae
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: RepositoryTest 어노테이션 추가
c511d2a
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: BasicAuthServiceTest 단위테스트로 변경
9ffb9e0
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: 회원 조회 서비스 단위테스트로 변경
fe674a7
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] refactor: 필요없는 코드 제거
3c06cb6
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: AboutServiceTest 단위테스트로 변경
ff326ad
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: BlogServiceTest 단위테스트로 변경
9f3487e
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: BlogSubscribeServiceTest 단위테스트로 변경
910e236
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: BlogSubscribeQueryServiceTest 단위테스트로 변경
6a756b6
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: CommentEventHandlerTest 단위테스트로 변경
2de814f
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: CommentServiceTest 단위테스트로 변경
e13342e
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: DraftServiceTest 단위테스트로 변경
2b970c5
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostCategoryServiceTest 단위테스트로 변경
38dec2e
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostLikeEventHandlerTest 단위테스트로 변경
1056c88
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostLikeServiceTest 단위테스트로 변경
b1e8518
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostServiceTest 단위테스트로 변경
5120240
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostStarEventHandlerTest 단위테스트로 변경
31d58a1
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostStarServiceTest 단위테스트로 변경
2e0aadb
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostCategoryServiceTest 테스트 추가
72483cc
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: StarGroupServiceTest 단위테스트로 변경
f4c6a9d
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: DraftQueryServiceTest 단위테스트로 변경
46dda13
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostCategoryQueryServiceTest 단위테스트로 변경
92a0ea8
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostManageQueryServiceTest 단위테스트로 변경
8cec83b
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostQueryServiceTest 단위테스트로 변경
51d739b
shin-mallang added a commit that referenced this issue Dec 16, 2023
@shin-mallang
[#160] test: PostSearchDaoTest 작성
d319815
@shin-mallang shin-mallang changed the title [✅ test] Service Layer 통합테스트에서 단위테스트로 변경 [✅ test] 테스트 간소화 Dec 19, 2023
@shin-mallang
Copy link
Member Author

shin-mallang commented Dec 19, 2023 •
edited
Loading

인수테스트 빼고 어느정도 지우는 것도..

https://youtu.be/gs1qM1TF5zA?si=k1Sp2Nqp6QbjclVO

오래걸리고, 오류가 발생해도 크리티컬한 것도 아니고, 그때 가서 쓰면 될둣..

자코코 떼내고 쿼리 테스트 지우면서 하는것도..?

shin-mallang added a commit that referenced this issue Jan 1, 2024
@shin-mallang
[#182, #160] build: jacoco test coverage 검사 제거
43cfe75
shin-mallang added a commit that referenced this issue Jan 1, 2024
@shin-mallang
[#160] build: sonarcloud test coverage 제거
c310774
shin-mallang added a commit that referenced this issue Jan 1, 2024
@shin-mallang
feat: 이미지 업로드를 위한 presigned url 생성 (#184)
e2b9589 
* [#182] build: s3 의존성 추가

* [#182] feat: presigned url 생성 client 작성

* [#182] feat: presigned url 생성 api 작성

* [#182, #160] build: jacoco test coverage 검사 제거

* [#182] test: 인수테스트 로그 제거

* [#182] feat: 이미지 파일 이름 랜덤 생성

* [#160] build: sonarcloud test coverage 제거
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✅ 테스트 🐌 나중에
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shin-mallang