Skip to content

[Feature Request] Adding header file for url_parser.pyx, and parser.pyx #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raceychan opened this issue Feb 16, 2025 · 1 comment
Open

Comments

@raceychan
Copy link

I would like to be able to use/extend classes/functions from parser.pyx and url_parser.pyx, however, currently I am not able to use it since its missing pxd files.

I can submit a PR if this is something you guys would agree with.

@raceychan
Copy link
Author

I did a quick scan through on parser.pyx, it seems that it works by receiving a python object, and inspect on the object to see what are the implemented callbacks, wouldn't it be easier and faster for the protocol object to just inherit from httptools.parser.HttpParser?

we don't need to do all those

if self._proto_on_xxx is not None:
    self._proto_on_xxx()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant