Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Commit 263a9fb

Browse files
authored
Automatically check for missing DLLs on Windows (#160)
1 parent b534622 commit 263a9fb

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

azure-pipelines.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- template: azure/windows.yml
1818
parameters:
1919
name: windows
20-
vmImage: vs2017-win2016
20+
vmImage: windows-2019
2121
matrix:
2222
py_3.8_32:
2323
PYTHON_VERSION: "3.8"

azure/windows.yml

+12-2
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,11 @@ jobs:
6868
pip install --timeout=60 $TEST_DEPENDS Cython==$CYTHON_BUILD_DEP
6969
pip install twine wheel
7070
pushd pandas
71-
cp "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Redist/MSVC/14.16.27012/$PYTHON_ARCH/Microsoft.VC141.CRT/msvcp140.dll" pandas/_libs/window
72-
cp "C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/VC/Redist/MSVC/14.16.27012/$PYTHON_ARCH/Microsoft.VC141.CRT/concrt140.dll" pandas/_libs/window
71+
cp "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Redist/MSVC/14.29.30133/$PYTHON_ARCH/Microsoft.VC142.CRT/msvcp140.dll" pandas/_libs/window
72+
cp "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Redist/MSVC/14.29.30133/$PYTHON_ARCH/Microsoft.VC142.CRT/concrt140.dll" pandas/_libs/window
73+
if [ "$PYTHON_ARCH" == "x64" ]; then
74+
cp "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Redist/MSVC/14.29.30133/x64/Microsoft.VC142.CRT/vcruntime140_1.dll" pandas/_libs/window
75+
fi
7376
python setup.py build
7477
python setup.py bdist_wheel
7578
ls dist
@@ -88,6 +91,13 @@ jobs:
8891
displayName: Install wheel and test
8992
condition: eq(variables['SKIP_BUILD'], 'false')
9093
94+
- script: |
95+
docker pull python:$(PYTHON_VERSION)-windowsservercore
96+
docker run -v %cd%:c:\pandas python:$(PYTHON_VERSION)-windowsservercore /pandas/check_windows_dlls.bat
97+
displayName: Ensure wheel imports correctly
98+
# No Windows images for x86
99+
condition: and(eq(variables['SKIP_BUILD'], 'false'), eq(variables['PYTHON_ARCH'], 'x64'))
100+
91101
- bash: echo "##vso[task.prependpath]$CONDA/Scripts"
92102
displayName: Add conda to PATH
93103
condition: and(succeeded(), eq(variables['SKIP_BUILD'], 'false'), ne(variables['Build.Reason'], 'PullRequest'))

check_windows_dlls.bat

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
python --version
2+
pip install pytz six numpy python-dateutil
3+
pip install --find-links=pandas/pandas/dist --no-index pandas
4+
python -c "import pandas as pd; print(pd.__version__)"

0 commit comments

Comments
 (0)