Stabilize tests

https://mitlibraries.atlassian.net/browse/USE-72

Author: JPrevost

app/controllers/search_controller.rb

@@ -1,15 +1,13 @@
 class SearchController < ApplicationController
   before_action :validate_q!, only: %i[results]
 
-  if Feature.enabled?(:geodata)
-    before_action :validate_geobox_presence!, only: %i[results]
-    before_action :validate_geobox_range!, only: %i[results]
-    before_action :validate_geobox_values!, only: %i[results]
-    before_action :validate_geodistance_presence!, only: %i[results]
-    before_action :validate_geodistance_range!, only: %i[results]
-    before_action :validate_geodistance_value!, only: %i[results]
-    before_action :validate_geodistance_units!, only: %i[results]
-  end
+  before_action :validate_geobox_presence!, only: %i[results]
+  before_action :validate_geobox_range!, only: %i[results]
+  before_action :validate_geobox_values!, only: %i[results]
+  before_action :validate_geodistance_presence!, only: %i[results]
+  before_action :validate_geodistance_range!, only: %i[results]
+  before_action :validate_geodistance_value!, only: %i[results]
+  before_action :validate_geodistance_units!, only: %i[results]
 
   def results
     # inject session preference for boolean type if it is present
@@ -185,6 +183,8 @@ def validate_q!
   end
 
   def validate_geodistance_presence!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geodistance]&.strip == 'true'
 
     geodistance_params = [params[:geodistanceLatitude]&.strip, params[:geodistanceLongitude]&.strip,
@@ -196,6 +196,8 @@ def validate_geodistance_presence!
   end
 
   def validate_geobox_presence!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geobox]&.strip == 'true'
 
     geobox_params = [params[:geoboxMinLatitude]&.strip, params[:geoboxMinLongitude]&.strip,
@@ -207,6 +209,8 @@ def validate_geobox_presence!
   end
 
   def validate_geodistance_range!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geodistance]&.strip == 'true'
 
     invalid_range = false
@@ -222,6 +226,8 @@ def validate_geodistance_range!
   end
 
   def validate_geobox_range!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geobox]&.strip == 'true'
 
     invalid_range = false
@@ -237,6 +243,8 @@ def validate_geobox_range!
   end
 
   def validate_geodistance_value!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geodistance]&.strip == 'true'
 
     distance = params[:geodistanceDistance]&.strip.to_i
@@ -247,6 +255,8 @@ def validate_geodistance_value!
   end
 
   def validate_geodistance_units!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geodistance]&.strip == 'true'
 
     distance = params[:geodistanceDistance]&.strip
@@ -265,6 +275,8 @@ def validate_geodistance_units!
   end
 
   def validate_geobox_values!
+    return unless Feature.enabled?(:geodata)
+
     return unless params[:geobox]&.strip == 'true'
 
     geobox_lat = [params[:geoboxMinLatitude]&.strip.to_f, params[:geoboxMaxLatitude]&.strip.to_f]