Respond to code review feedback

* Use more idiomatic .present? method in tacos_enabled? helper

* Update the default TACOS_SOURCE value to be specific to this
  codebase, rather than a generic "unset"

* Rename the Tacos model method .call to .analyze

Author: matt-bernhardt

app/controllers/tacos_controller.rb

@@ -4,6 +4,6 @@ class TacosController < ApplicationController
   def analyze
     return unless ApplicationHelper.tacos_enabled?
 
-    Tacos.call(params[:q])
+    Tacos.analyze(params[:q])
   end
 end

app/helpers/application_helper.rb

@@ -1,6 +1,6 @@
 module ApplicationHelper
   def tacos_enabled?
-    ENV.fetch('TACOS_URL', '').length > 0
+    ENV.fetch('TACOS_URL', '').present?
   end
   module_function :tacos_enabled?
 

app/models/tacos.rb

@@ -2,7 +2,7 @@ class Tacos
   # The tacos_client argument here is unused in production - it is provided for
   # our test suite so that we can mock various error conditions to ensure that
   # error handling happens as we intend.
-  def self.call(term, tacos_client = nil)
+  def self.analyze(term, tacos_client = nil)
     tacos_http = setup(tacos_client)
     query = '{ "query": "{ logSearchEvent(searchTerm: \"' + clean_term(term) + '\", sourceSystem: \"' + tacos_source + '\" ) { phrase source detectors { suggestedResources { title url } } } }" }'
     begin
@@ -30,7 +30,7 @@ def self.origins
   end
 
   # We define the HTTP connection this way so that it can be overridden during
-  # testing, to make sure that the .call method can handle specific error
+  # testing, to make sure that the .analyze method can handle specific error
   # conditions.
   def self.setup(tacos_client)
     tacos_client || HTTP.persistent(tacos_url)
@@ -40,7 +40,7 @@ def self.setup(tacos_client)
   end
 
   def self.tacos_source
-    ENV.fetch('TACOS_SOURCE', 'unset')
+    ENV.fetch('TACOS_SOURCE', 'timdexui_unset')
   end
 
   def self.tacos_url

test/models/tacos_test.rb

@@ -25,7 +25,7 @@ class TacosTest < ActiveSupport::TestCase
     VCR.use_cassette('tacos popcorn') do
       searchterm = 'popcorn'
 
-      result = Tacos.call(searchterm)
+      result = Tacos.analyze(searchterm)
 
       assert_instance_of Hash, result
       assert_equal searchterm, result['data']['logSearchEvent']['phrase']
@@ -35,7 +35,7 @@ class TacosTest < ActiveSupport::TestCase
   test 'TACOS model will use ENV to populate the sourceSystem value' do
     VCR.use_cassette('tacos fake system') do
       ClimateControl.modify(TACOS_SOURCE: 'faked') do
-        result = Tacos.call('popcorn')
+        result = Tacos.analyze('popcorn')
 
         assert_equal 'faked', result['data']['logSearchEvent']['source']
       end
@@ -45,7 +45,7 @@ class TacosTest < ActiveSupport::TestCase
   test 'TACOS model catches connection errors' do
     tacos_client = TacosConnectionError.new
 
-    result = Tacos.call('popcorn', tacos_client)
+    result = Tacos.analyze('popcorn', tacos_client)
 
     assert_instance_of Hash, result
     assert_equal 'A connection error has occurred', result['error']
@@ -54,7 +54,7 @@ class TacosTest < ActiveSupport::TestCase
   test 'TACOS model catches parsing errors' do
     tacos_client = TacosParsingError.new
 
-    result = Tacos.call('popcorn', tacos_client)
+    result = Tacos.analyze('popcorn', tacos_client)
 
     assert_instance_of Hash, result
     assert_equal 'A parsing error has occurred', result['error']