Skip to content

Commit d229e49

Browse files
Respond to ADR feedback
1 parent 6e13e7e commit d229e49

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

docs/architecture-decisions/0005-implement-an-accessible-navigation-system.md

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,19 @@ for an accessible navigation menu for web application.
8989
There are several significant drawbacks to using this menu library.
9090

9191
* The most significant drawback is that it imposes some operating costs on users
92-
of assistive technology that are not ideal. Our recent accessibility testing
93-
[included some details about this problem](https://github.mit.edu/Accessibility-FY2024/omeka/issues/4#issuecomment-182190) while we discussed this menu issue.
92+
of assistive technology that are not ideal. The library forces the screen
93+
reader user to explicitly switch operating mode to interact with the menu, and
94+
does not listen for the type of interaction events which users naturally
95+
generate while navigating a page.
96+
97+
> However, the library is not listening for click events; it seems they are
98+
> only listening for explicit pointer events. This means you need to switch
99+
> into forms mode, then press enter or space, to activate a menu ... It also
100+
> seems they are handling keyboard events explicitly for keys that should
101+
> normally be handled by the browser like tab and shift+tab.
102+
103+
(The above comment comes from [our discussion of the navigation menu after
104+
accessibility testing](https://github.mit.edu/Accessibility-FY2024/omeka/issues/4#issuecomment-182190).)
94105

95106
* The markup requirements for this library do not immediately align with the
96107
markup generated by Omeka. While this is manageable by either maintaining a
@@ -175,10 +186,11 @@ Ultimately, though, the review which we've conducted of existing menu libraries
175186
has not identified such a suitable existing library at this time.
176187

177188

178-
## Decision
189+
## Decision: Option 4
179190

180-
We will develop, and maintain, a small set of javascript and stylesheet rules
181-
for the navigation menu in this theme.
191+
We will implement option 4 - a bespoke solution. We will develop, and maintain,
192+
a small set of javascript and stylesheet rules for the navigation menu in this
193+
theme.
182194

183195
If this proves sustainable, the feature will be considered for promotion to the
184196
overall style library in order to make the feature available to our other

0 commit comments

Comments
 (0)