Skip to content

Commit 1b56759

Browse files
hyeoksu-leeHyeoksu LeeHyeoksu LeeHyeoksu Leesbryngelson
authored
Update modules for Carpenter (#527)
Co-authored-by: Hyeoksu Lee <[email protected]> Co-authored-by: Hyeoksu Lee <[email protected]> Co-authored-by: Hyeoksu Lee <[email protected]> Co-authored-by: Spencer Bryngelson <[email protected]>
1 parent a6bd2ed commit 1b56759

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

.github/workflows/coverage.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,11 @@ jobs:
4040
run: /bin/bash mfc.sh test -a -j $(nproc)
4141

4242
- name: Upload coverage reports to Codecov
43-
uses: codecov/codecov-action@v4.0.1
43+
uses: codecov/codecov-action@v4.5.0
4444
with:
4545
token: ${{ secrets.CODECOV_TOKEN }}
4646
fail_ci_if_error: true
4747
verbose: true
48-
version: v0.6.0
4948
env:
5049
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
5150

toolchain/bootstrap/modules.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ while [[ $# -gt 0 ]]; do
1616
esac
1717
done
1818

19-
# Get computer (if not supplied in command-line)
19+
# Get computer (if not supplied in command line)
2020
if [ -v $u_c ]; then
2121
log "Select a system:"
2222
log "$G""ORNL$W: Ascent (a) | Frontier (f) | Summit (s) | Wombat (w)"
@@ -66,8 +66,8 @@ fi
6666

6767
log "Loading modules (& env variables) for $M$COMPUTER$CR on $M$CG$CR"'s:'
6868

69-
# Reset modules to default system configuration
70-
if [ "$u_c" != 'p' ]; then
69+
# Reset modules to default system configuration (unless Phoenix or Carpenter)
70+
if [ "$u_c" != 'p' ] && [ "$u_c" != 'c' ]; then
7171
module reset > /dev/null 2>&1
7272
code="$?"
7373

@@ -102,7 +102,8 @@ for element in ${ELEMENTS[@]}; do
102102
fi
103103
done
104104

105-
if [ ! -z ${CRAY_LD_LIBRARY_PATH+x} ]; then
105+
# Don't check for Cray paths on Carpenter, otherwise do check if they exist
106+
if [ ! -z ${CRAY_LD_LIBRARY_PATH+x} ] && [ "$u_c" != 'c' ]; then
106107
ok "Found $M\$CRAY_LD_LIBRARY_PATH$CR. Prepending to $M\$LD_LIBRARY_PATH$CR."
107108
export LD_LIBRARY_PATH="$CRAY_LD_LIBRARY_PATH:$LD_LIBRARY_PATH"
108109
fi

toolchain/modules

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@ d-gpu nvhpc/22.11 openmpi+cuda/4.1.5+cuda cmake
6161
d-gpu CC=nvc CXX=nvc++ FC=nvfortran
6262

6363
c DoD Carpenter
64-
c-all python
65-
c-cpu gcc/12.2.0 cmake/3.28.1-gcc-12.2.0 openmpi/4.1.6
66-
c-gpu nvhpc/23.7 cuda/12.2
64+
c-all python/3.12.1
65+
c-cpu compiler-rt/2024.2.0 ifort/2024.2.0 icc/2023.1.0 mpi/latest cmake/3.28.1-intel-2023.0.0
66+
c-cpu CC=gcc CXX=g++ FC=gfortran
6767

6868
n DoD Nautilus
6969
n-all slurm
7070
n-cpu penguin/openmpi/4.1.5/gcc-8.5.0
7171
n-gpu penguin/openmpi/4.1.5/nvhpc-22.3 nvidia/nvhpc/22.3 cuda/cuda-11.6
72-
n-gpu CC=nvc CXX=nvc++ FC=nvfortran
72+
n-gpu CC=nvc CXX=nvc++ FC=nvfortran

toolchain/templates/carpenter.mako

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ cd "${MFC_ROOTDIR}"
2929
cd - > /dev/null
3030
echo
3131

32-
3332
% for target in targets:
3433
${helpers.run_prologue(target)}
3534

@@ -40,7 +39,7 @@ echo
4039
mpirun -np ${nodes*tasks_per_node} \
4140
"${target.get_install_binpath(case)}")
4241
% endif
43-
42+
4443
${helpers.run_epilogue(target)}
4544

4645
echo

0 commit comments

Comments
 (0)