fix: add back client logic for handling mcp.json #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelojimenez
previously approved these changes
Sep 11, 2025
Contributor
chelojimenez
left a comment
chelojimenez
left a comment
There was a problem hiding this comment.
lgtm! please run npm prettier-fix before merging
Contributor
|
tested with: |
Contributor
|
created a PR so we update or docs to let devs know about this. we starting an open source repo for community mantained docs at https://docs.mcpjam.com/ if you wanna check it out! |
Contributor
|
branch was failing bc our gh check was using a different node version, so i merged this! |
khandrew1
pushed a commit
that referenced
this pull request
Nov 15, 2025
* fix: add back client logic for handling mcp.json * fix: update server handling logic to always add/update from CLI config * add support for sse/http auto connections from mcp.json * run prettier script --------- Co-authored-by: marcelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #499 reverted some logic in
useAppStatehook inuse-app-state.tsfor handlingmcp.jsoncli connection logic from #490.This pull request updates the logic for auto-connecting to mcp.json provided MCP servers in the
useAppStatehook. Added code back that fetches the mcp configuration from an API endpoint instead of relying on a global window variable, supports multiple servers, and improves handling for auto-connect scenarios. The main changes are grouped below:MCP Configuration Loading and Processing:
window.MCP_CLI_CONFIGwith a fetch call to/api/mcp-cli-configto retrieve the mcp configuration, making it compatible with both development and production environments.autoConnectServer).Robustness and Logging Enhancements:
cliConfigProcessedRef) to ensure the mcp config is processed only once per mount, preventing duplicate connections.