Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction receipts all in one batch call #708

Open
bertllll opened this issue May 26, 2023 · 0 comments
Open

Transaction receipts all in one batch call #708

bertllll opened this issue May 26, 2023 · 0 comments
Labels
enhancement New feature or request hardenning Getting a feature working stronger

Comments

@bertllll
Copy link

bertllll commented May 26, 2023

Before you pick this card, make sure you understand the requirements imposed by #782!

At the moment, the BlockchainBridge processes requests of transaction receipts in iterations, repeating contacting the blockchain service as many times as how many pending transactions have been found on the Accountant's side.

Making requests like that is inefficient and the blockchain service provider can punish us with a limit to it. We should implement the batch system, implemented at other places already, also here in order to get better performance, and maybe avoid hitting rate limits if it matters.

Suggestion: some inspiration about implementing the batch request can be seen in the paying mechanism for payables.

Note: this will greatly reduce the API rate overheads of the endpoint use

@bertllll bertllll added enhancement New feature or request hardenning Getting a feature working stronger labels Jul 12, 2023
@bertllll bertllll changed the title Ask for transaction receipts in batch Transaction receipts in a batch Aug 21, 2023
@bertllll bertllll changed the title Transaction receipts in a batch Transaction receipts in a batch call Aug 21, 2023
@bertllll bertllll changed the title Transaction receipts in a batch call Transaction Receipts all in one batch call Mar 31, 2024
@bertllll bertllll changed the title Transaction Receipts all in one batch call Transaction receipts all in one batch call Mar 31, 2024
@kauri-hero kauri-hero moved this to Ready for Development in MASQ Node v2 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hardenning Getting a feature working stronger
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant