Add rector

Author: M-arcus

.gitignore

@@ -4,3 +4,6 @@
 
 # ecs
 /.ecs-cache
+
+# rector
+/.rector-cache

composer.json

@@ -2,7 +2,7 @@
     "name": "m_arcus/php-fints-wrapper",
     "description": "A simple wrapper for nemiah/php-fints",
     "type": "library",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "require": {
         "nemiah/php-fints": "^3.4"
     },
@@ -19,6 +19,7 @@
         }
     ],
     "require-dev": {
-        "symplify/easy-coding-standard": "^12.1"
+        "symplify/easy-coding-standard": "^12.1",
+        "rector/rector": "^1.0"
     }
 }

rector.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+use PHPStan\Cache\FileCacheStorage;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\SetList;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/ecs.php',
+        __DIR__ . '/rector.php',
+        __DIR__ . '/src',
+    ])
+    ->withCache(__DIR__ . '/.rector-cache')
+    ->withSets([
+        SetList::CODE_QUALITY,
+        SetList::CODING_STYLE,
+        SetList::DEAD_CODE,
+        SetList::STRICT_BOOLEANS,
+        SetList::PRIVATIZATION,
+        SetList::TYPE_DECLARATION,
+        SetList::EARLY_RETURN,
+        SetList::INSTANCEOF,
+    ]);

src/ActionService.php

@@ -24,7 +24,7 @@ public static function login(FinTs $finTs): void
         }
     }
 
-    public static function action(FinTs $finTs, BaseAction $action)
+    public static function action(FinTs $finTs, BaseAction $action): void
     {
         $finTs->execute($action);
 
@@ -59,7 +59,7 @@ public static function action(FinTs $finTs, BaseAction $action)
      */
     public static function handleStrongAuthentication(FinTs $finTs, BaseAction $action): void
     {
-        if ($finTs->getSelectedTanMode()?->isDecoupled()) {
+        if ($finTs->getSelectedTanMode()?->isDecoupled() === true) {
             self::handleDecoupled($finTs, $action);
         } else {
             self::handleTan($finTs, $action);
@@ -79,13 +79,14 @@ protected static function handleTan(FinTs $finTs, BaseAction $action): void
         if ($tanRequest?->getChallenge() !== null) {
             echo ' Instructions: ' . $tanRequest?->getChallenge();
         }
+
         echo "\n";
         if ($tanRequest?->getTanMediumName() !== null) {
             echo 'Please use this device: ' . $tanRequest?->getTanMediumName() . "\n";
         }
 
         // Challenge Image for PhotoTan/ChipTan
-        if ($tanRequest?->getChallengeHhdUc()) {
+        if ($tanRequest?->getChallengeHhdUc() instanceof \Fhp\Syntax\Bin) {
             try {
                 $flicker = new TanRequestChallengeFlicker($tanRequest?->getChallengeHhdUc());
                 echo 'There is a challenge flicker.' . PHP_EOL;
@@ -117,7 +118,7 @@ protected static function handleTan(FinTs $finTs, BaseAction $action): void
         echo "Please enter the TAN:\n";
         $tan = trim(fgets(STDIN));
 
-        echo "Submitting TAN: $tan\n";
+        echo sprintf('Submitting TAN: %s%s', $tan, PHP_EOL);
         $finTs->submitTan($action, $tan);
     }
 
@@ -135,6 +136,7 @@ protected static function handleDecoupled(FinTs $finTs, BaseAction $action): voi
         if ($tanRequest?->getChallenge() !== null) {
             echo ' Instructions: ' . $tanRequest?->getChallenge();
         }
+
         echo "\n";
         if ($tanRequest?->getTanMediumName() !== null) {
             echo 'Please check this device: ' . $tanRequest?->getTanMediumName() . "\n";
@@ -145,7 +147,7 @@ protected static function handleDecoupled(FinTs $finTs, BaseAction $action): voi
         // browser). This PHP sample code just serves to show the *logic* of the polling. Alternatively, you can even do
         // without polling entirely and just let the user confirm manually in all cases (i.e. only implement the `else`
         // branch below).
-        if ($tanMode?->allowsAutomatedPolling()) {
+        if ($tanMode?->allowsAutomatedPolling() === true) {
             echo "Polling server to detect when the decoupled authentication is complete.\n";
             sleep($tanMode?->getFirstDecoupledCheckDelaySeconds());
             for ($attempt = 0;
@@ -156,20 +158,24 @@ protected static function handleDecoupled(FinTs $finTs, BaseAction $action): voi
                     echo "Confirmed.\n";
                     return;
                 }
+
                 echo "Still waiting...\n";
                 sleep($tanMode?->getPeriodicDecoupledCheckDelaySeconds());
             }
-            throw new RuntimeException("Not confirmed after $attempt attempts, which is the limit.");
+
+            throw new RuntimeException(sprintf('Not confirmed after %d attempts, which is the limit.', $attempt));
         }
 
-        if ($tanMode?->allowsManualConfirmation()) {
+        if ($tanMode?->allowsManualConfirmation() === true) {
             do {
                 echo "Please type 'done' and hit Return when you've completed the authentication on the other device.\n";
                 while (trim(fgets(STDIN)) !== 'done') {
                     echo "Try again.\n";
                 }
+
                 echo "Confirming that the action is done.\n";
             } while (! $finTs->checkDecoupledSubmission($action));
+
             echo "Confirmed\n";
         } else {
             throw new AssertionError('Server allows neither automated polling nor manual confirmation');