Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convolutional VAE for MNIST using Reactant failed to produce right results #1274

Open
Yangyang-Tan opened this issue Mar 25, 2025 · 5 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Yangyang-Tan
Copy link

The Reactant example in the document failed to produce the right results for the latest version.
https://lux.csail.mit.edu/dev/tutorials/intermediate/5_ConvolutionalVAE

Image

@Yangyang-Tan
Copy link
Author

I also get lots of warnings like the following:

E0000 00:00:1742930830.945941 2247005 buffer_comparator.cc:156] Difference at 4096: nan, expected 35.3139 E0000 00:00:1742930830.945957 2247005 buffer_comparator.cc:156] Difference at 4097: nan, expected 33.723 E0000 00:00:1742930830.945961 2247005 buffer_comparator.cc:156] Difference at 4098: nan, expected 30.5046 E0000 00:00:1742930830.945964 2247005 buffer_comparator.cc:156] Difference at 4099: nan, expected 31.9991 E0000 00:00:1742930830.945967 2247005 buffer_comparator.cc:156] Difference at 4100: nan, expected 32.3158 E0000 00:00:1742930830.945970 2247005 buffer_comparator.cc:156] Difference at 4101: nan, expected 31.243 E0000 00:00:1742930830.945989 2247005 buffer_comparator.cc:156] Difference at 4102: nan, expected 32.8456 E0000 00:00:1742930830.945992 2247005 buffer_comparator.cc:156] Difference at 4103: nan, expected 34.6195 E0000 00:00:1742930830.945995 2247005 buffer_comparator.cc:156] Difference at 4104: nan, expected 35.1943 E0000 00:00:1742930830.945999 2247005 buffer_comparator.cc:156] Difference at 4105: nan, expected 31.1287 2025-03-25 19:27:10.946004: E external/xla/xla/service/gpu/autotuning/gemm_fusion_autotuner.cc:1137] Results do not match the reference. This is likely a bug/unexpected loss of precision.

@avik-pal
Copy link
Member

probably related to EnzymeAD/Reactant.jl#444

@avik-pal
Copy link
Member

Can confirm that this is a bug. I will fix this upstream first EnzymeAD/Reactant.jl#1042 and then port over the changes

@avik-pal avik-pal added the bug Something isn't working label Mar 26, 2025
@avik-pal avik-pal self-assigned this Mar 26, 2025
@avik-pal avik-pal added the documentation Improvements or additions to documentation label Mar 26, 2025
@Yangyang-Tan
Copy link
Author

Hi Avik, this still failed for the latest build of Reactant.

@avik-pal
Copy link
Member

avik-pal commented Apr 1, 2025

yeah we need to use the config, and see if that gets rid of the buffer comparator failures. I am a bit swamped because of a deadline on 15th April, I will take a closer look after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants