Skip to content

Commit ed71d80

Browse files
authored
fix(exmaples): actix web should use TokioCurrentThread as runtime (open-telemetry#734)
1 parent b695ba1 commit ed71d80

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

examples/actix-http/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ publish = false
66

77
[dependencies]
88
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio"] }
9-
opentelemetry-jaeger = { path = "../../opentelemetry-jaeger", features = ["reqwest_collector_client", "rt-tokio"] }
9+
opentelemetry-jaeger = { path = "../../opentelemetry-jaeger", features = ["reqwest_collector_client", "rt-tokio-current-thread"] }
1010
thrift = "0.13"
1111
actix-web = "4.0.0-beta.4"
1212
actix-service = "2.0.0-beta.5"

examples/actix-http/src/main.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
use actix_service::Service;
22
use actix_web::middleware::Logger;
33
use actix_web::{web, App, HttpServer};
4+
use opentelemetry::global::shutdown_tracer_provider;
45
use opentelemetry::trace::TraceError;
56
use opentelemetry::{global, sdk::trace as sdktrace};
67
use opentelemetry::{
@@ -12,7 +13,7 @@ fn init_tracer() -> Result<sdktrace::Tracer, TraceError> {
1213
opentelemetry_jaeger::new_pipeline()
1314
.with_collector_endpoint("http://127.0.0.1:14268/api/traces")
1415
.with_service_name("trace-http-demo")
15-
.install_batch(opentelemetry::runtime::Tokio)
16+
.install_batch(opentelemetry::runtime::TokioCurrentThread)
1617
}
1718

1819
async fn index() -> &'static str {
@@ -45,5 +46,10 @@ async fn main() -> std::io::Result<()> {
4546
.bind("127.0.0.1:8088")
4647
.unwrap()
4748
.run()
48-
.await
49+
.await?;
50+
51+
// wait until all pending spans get exported.
52+
shutdown_tracer_provider();
53+
54+
Ok(())
4955
}

0 commit comments

Comments
 (0)