Skip to content

Commit cdd8fa0

Browse files
authored
Remove serialize feature (open-telemetry#738)
Removes non-spec serialization support to reduce public API surface area.
1 parent dacd75a commit cdd8fa0

File tree

31 files changed

+36
-168
lines changed

31 files changed

+36
-168
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
override: true
7373
- name: Run tests
7474
run: cargo --version &&
75-
cargo test --verbose --manifest-path=opentelemetry/Cargo.toml --features trace,metrics,serialize,rt-tokio,testing &&
75+
cargo test --verbose --manifest-path=opentelemetry/Cargo.toml --features trace,metrics,rt-tokio,testing &&
7676
cargo test --manifest-path=opentelemetry-jaeger/Cargo.toml --features rt-tokio &&
7777
cargo test --manifest-path=opentelemetry-zipkin/Cargo.toml
7878
cargo-deny:

examples/basic-otlp-http/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ edition = "2018"
55
publish = false
66

77
[dependencies]
8-
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics", "serialize"] }
8+
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics"] }
99
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = ["http-proto", "reqwest-client"] }
1010
tokio = { version = "1.0", features = ["full"] }

examples/basic-otlp-with-selector/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ publish = false
77
[dependencies]
88
futures-util = { version = "0.3", default-features = false, features = ["std"] }
99
lazy_static = "1.4"
10-
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics", "serialize"] }
10+
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics"] }
1111
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = ["tonic", "metrics"] }
1212
serde_json = "1.0"
1313
tokio = { version = "1.0", features = ["full"] }

examples/basic-otlp/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ publish = false
77
[dependencies]
88
futures-util = { version = "0.3", default-features = false, features = ["std"] }
99
lazy_static = "1.4"
10-
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics", "serialize"] }
10+
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics"] }
1111
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = ["tonic", "metrics"] }
1212
serde_json = "1.0"
1313
tokio = { version = "1.0", features = ["full"] }

examples/basic/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ publish = false
77
[dependencies]
88
futures-util = { version = "0.3", default-features = false, features = ["std"] }
99
lazy_static = "1.4"
10-
opentelemetry = { path = "../../opentelemetry", features = ["serialize", "rt-tokio", "metrics"] }
10+
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics"] }
1111
opentelemetry-jaeger = { path = "../../opentelemetry-jaeger", features = ["rt-tokio"] }
12-
serde_json = "1.0"
1312
thrift = "0.13"
1413
tokio = { version = "1.0", features = ["full"] }

examples/basic/src/main.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use opentelemetry::sdk::{metrics::PushController, trace as sdktrace, Resource};
66
use opentelemetry::trace::TraceError;
77
use opentelemetry::{
88
baggage::BaggageExt,
9-
metrics::{MetricsError, ObserverResult},
9+
metrics::ObserverResult,
1010
trace::{TraceContextExt, Tracer},
1111
Context, Key, KeyValue,
1212
};
@@ -29,13 +29,7 @@ fn delayed_interval(duration: Duration) -> impl Stream<Item = tokio::time::Insta
2929
}
3030

3131
fn init_meter() -> PushController {
32-
opentelemetry::sdk::export::metrics::stdout(tokio::spawn, delayed_interval)
33-
.with_formatter(|batch| {
34-
serde_json::to_value(batch)
35-
.map(|value| value.to_string())
36-
.map_err(|err| MetricsError::Other(err.to_string()))
37-
})
38-
.init()
32+
opentelemetry::sdk::export::metrics::stdout(tokio::spawn, delayed_interval).init()
3933
}
4034

4135
const FOO_KEY: Key = Key::from_static_str("ex.com/foo");

examples/dynatrace/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ publish = false
88
futures = "0.3"
99
http = "0.2"
1010
lazy_static = "1.4"
11-
opentelemetry = { path = "../../opentelemetry", default-features = false, features = ["trace", "serialize"] }
11+
opentelemetry = { path = "../../opentelemetry", default-features = false, features = ["trace"] }
1212
opentelemetry-dynatrace = { path = "../../opentelemetry-dynatrace" }
1313
opentelemetry-http = { path = "../../opentelemetry-http", default-features = false }
1414
opentelemetry-otlp = { path = "../../opentelemetry-otlp", default-features = false, features = ["http-proto", "reqwest-client"] }

examples/external-otlp-grpcio-async-std/Cargo.toml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ publish = false
77
[dependencies]
88
async-std = { version = "1.9.0", features = ["attributes"] }
99
env_logger = "0.8.2"
10-
opentelemetry = { path = "../../opentelemetry", features = [
11-
"rt-async-std",
12-
"serialize"
13-
] }
10+
opentelemetry = { path = "../../opentelemetry", features = ["rt-async-std"] }
1411
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = [
1512
"grpc-sys",
1613
"trace",

examples/external-otlp-tonic-tokio/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ edition = "2018"
55
publish = false
66

77
[dependencies]
8-
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics", "serialize"] }
8+
opentelemetry = { path = "../../opentelemetry", features = ["rt-tokio", "metrics"] }
99
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = ["tonic", "tls", "tls-roots"] }
1010
serde_json = "1.0"
1111
tokio = { version = "1.0", features = ["full"] }

opentelemetry-api/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ futures-channel = "0.3"
99
futures-util = { version = "0.3", default-features = false, features = ["std", "sink"] }
1010
lazy_static = "1.4"
1111
pin-project = { version = "1.0.2", optional = true }
12-
serde = { version = "1.0", features = ["derive", "rc"], optional = true }
1312
thiserror = "1"
1413
tokio-stream = { version = "0.1", optional = true }
1514

@@ -24,5 +23,4 @@ js-sys = "0.3"
2423
default = ["trace"]
2524
trace = ["pin-project"]
2625
metrics = ["fnv"]
27-
serialize = ["serde"]
2826
testing = ["trace"]

0 commit comments

Comments
 (0)