fix #2214

Author: sumneko

changelog.md

@@ -1,5 +1,10 @@
 # changelog
 
+## 3.6.25
+* `FIX` [#2214]
+
+[#2214]: https://github.com/LuaLS/lua-language-server/issues/2145
+
 ## 3.6.24
 `2023-7-21`
 * `NEW` diagnostic: `missing-fields`

script/core/diagnostics/missing-fields.lua

@@ -16,19 +16,24 @@ return function (uri, callback)
         await.delay()
 
         local defs = vm.getDefs(src)
-        local requiresKeys = {}
-        local isClass = false
+        for _, def in ipairs(defs) do
+            if def.type == 'doc.class' and def.bindSource then
+                if guide.isInRange(def.bindSource, src.start) then
+                    return
+                end
+            end
+            if def.type == 'doc.type.array'
+            or def.type == 'doc.type.table' then
+                return
+            end
+        end
         for _, def in ipairs(defs) do
             if def.type == 'doc.class' then
                 if not def.fields then
-                    goto continue
-                end
-                if def.bindSource then
-                    if guide.isInRange(def.bindSource, src.start) then
-                        isClass = true
-                        break
-                    end
+                    return
                 end
+
+                local requiresKeys = {}
                 for _, field in ipairs(def.fields) do
                     if  not field.optional
                     and not vm.compileNode(field):isNullable() then
@@ -39,37 +44,35 @@ return function (uri, callback)
                         end
                     end
                 end
-            end
-            ::continue::
-        end
 
-        if #requiresKeys == 0 or isClass then
-            return
-        end
+                if #requiresKeys == 0 then
+                    return
+                end
+                local myKeys = {}
+                for _, field in ipairs(src) do
+                    local key = vm.getKeyName(field)
+                    if key then
+                        myKeys[key] = true
+                    end
+                end
 
-        local myKeys = {}
-        for _, field in ipairs(src) do
-            local key = vm.getKeyName(field)
-            if key then
-                myKeys[key] = true
-            end
-        end
+                local missedKeys = {}
+                for _, key in ipairs(requiresKeys) do
+                    if not myKeys[key] then
+                        missedKeys[#missedKeys+1] = ('`%s`'):format(key)
+                    end
+                end
 
-        local missedKeys = {}
-        for _, key in ipairs(requiresKeys) do
-            if not myKeys[key] then
-                missedKeys[#missedKeys+1] = ('`%s`'):format(key)
-            end
-        end
+                if #missedKeys == 0 then
+                    return
+                end
 
-        if #missedKeys == 0 then
-            return
+                callback {
+                    start   = src.start,
+                    finish  = src.finish,
+                    message = lang.script('DIAG_MISSING_FIELDS', table.concat(missedKeys, ', ')),
+                }
+            end
         end
-
-        callback {
-            start   = src.start,
-            finish  = src.finish,
-            message = lang.script('DIAG_MISSING_FIELDS', table.concat(missedKeys, ', ')),
-        }
     end)
 end

test/diagnostics/common.lua

@@ -2431,3 +2431,42 @@ TEST [[
 ---@class A
 local t = {}
 ]]
+
+TEST [[
+---@diagnostic disable: unused-local
+
+---@class Foo
+---@field a number
+---@field b number
+---@field c number
+
+---@type Foo|Foo[]
+local a = {
+    {
+        a = 1,
+        b = 2,
+        c = 3,
+    }
+}
+]]
+
+TEST [[
+---@diagnostic disable: unused-local
+
+---@class Foo
+---@field a number
+---@field b number
+---@field c number
+
+---@class Bar
+---@field ba number
+---@field bb number
+---@field bc number
+
+---@type Foo|Bar
+local b = {
+    a = 1,
+    b = 2,
+    c = 3,
+}
+]]