Skip to content

Commit b9400e0

Browse files
committed
resolve #973 don't show telemetry in non-VSCode
avoid repeated prompts in non-VSCode due to the inability to automatically modify the settings
1 parent 28b3ab1 commit b9400e0

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 2.6.7
44
* `NEW` offline diagnostic, [read more](https://github.com/sumneko/lua-language-server/wiki/Offline-Diagnostic)
55
* `CHG` `VSCode`: 1.65 has built in new `Lua` syntax files, so this extension no longer provides syntax files, which means you can install other syntax extensions in the marketplace. If you have any suggestions or issues, please [open issues here](https://github.com/sumneko/lua.tmbundle).
6+
* `CHG` telemetry: the prompt will only appear in VSCode to avoid repeated prompts in other platforms due to the inability to automatically modify the settings.
67
* `FIX` [#965](https://github.com/sumneko/lua-language-server/issues/965)
78
* `FIX` [#975](https://github.com/sumneko/lua-language-server/issues/975)
89

script/service/telemetry.lua

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ local function pushErrorLog(link)
9090
))
9191
end
9292

93-
local validMap = {}
9493
local isValid = false
9594

9695
timer.wait(5, function ()
@@ -145,6 +144,9 @@ function m.updateConfig()
145144
if isValid ~= nil then
146145
return
147146
end
147+
if not client.getOption 'changeConfiguration' then
148+
return
149+
end
148150
if m.hasShowedMessage then
149151
return
150152
end

0 commit comments

Comments
 (0)