-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes healthcheck #98
Comments
Hi, thanks for the hit, but that' not really what i'm looking for. I'm not sure but i think we are missing something here, or maybe we should implement it. Because it says "https://github.com/grpc/grpc/blob/master/doc/health-checking.md" |
Do you have the idea what they mean by 'general server health'? Have you seen any examples? |
according to the code directly it's suppose to check all the grpc service, but it's still experimental, I also try to look into there code i didn't find any specific implementation of that so i'm wondering if the server had to implement or not.
|
The main issue here is that See also: Maybe you should open an issue in the grpc-java repo for this. |
Hi thanks, for the answer. I asked the question here:
|
I've implemented this in our micro service. We also added into our base image grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe binary. And then we use the kubernetes exec in livenessProbe and readinessProbe. But yes you need to implement the Check method. |
FYI, Supported via custom ManagedHealthStatusService. |
Hi,
I'm using the starter and i'm seeing that it actually exposes the grpc.health.v1.Health.Check. So in this case should we implement in our own a general server status. Because for now i can check only when i specify the name of the service in healthcheck, but when i use an empty service name it returns an error of unknown service,
"The server should use an empty string as the key for server's overall health status, so that a client not interested in a specific service can query the server's status with an empty request." https://github.com/grpc/grpc/blob/v1.15.0/doc/health-checking.md,
i'm actually deploying in kubernetes and i'm trying to use this grpc-health-probe
https://github.com/grpc-ecosystem/grpc-health-probe
Does it mean that i have to implement my own implementation, i'm not able to find the right answer for that.
Thanks
The text was updated successfully, but these errors were encountered: