You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the generate_proposal_points function, there are locations in the code that adjust (reflect) parameters that are outside of their prior ranges to be within their specified ranges (when hardboundaries=True, the default condition). The code used to do this relies on if statements to check the conditions. There is a note that "#Occasionally reflection will result in points still outside of boundaries", and then reflection is only applied once more with another set of if statements. But, I don't think applying a reflection once more guarantees that the parameters will be in their prior boundaries. It seems like a while loop is instead needed for this whole section of code to continually reflect the points until the parameters are in their boundaries.
Line example: 728 - 744 of Dream.py
I have not tested this thought, but I wanted to report this perceived issue.
The text was updated successfully, but these errors were encountered:
In the generate_proposal_points function, there are locations in the code that adjust (reflect) parameters that are outside of their prior ranges to be within their specified ranges (when hardboundaries=True, the default condition). The code used to do this relies on if statements to check the conditions. There is a note that "#Occasionally reflection will result in points still outside of boundaries", and then reflection is only applied once more with another set of if statements. But, I don't think applying a reflection once more guarantees that the parameters will be in their prior boundaries. It seems like a while loop is instead needed for this whole section of code to continually reflect the points until the parameters are in their boundaries.
Line example: 728 - 744 of Dream.py
I have not tested this thought, but I wanted to report this perceived issue.
The text was updated successfully, but these errors were encountered: