Skip to content

While loop needed instead of if statements in generate_proposal_points function for hardboundaries reflections? #9

Open
@jds485

Description

@jds485

In the generate_proposal_points function, there are locations in the code that adjust (reflect) parameters that are outside of their prior ranges to be within their specified ranges (when hardboundaries=True, the default condition). The code used to do this relies on if statements to check the conditions. There is a note that "#Occasionally reflection will result in points still outside of boundaries", and then reflection is only applied once more with another set of if statements. But, I don't think applying a reflection once more guarantees that the parameters will be in their prior boundaries. It seems like a while loop is instead needed for this whole section of code to continually reflect the points until the parameters are in their boundaries.

Line example: 728 - 744 of Dream.py

I have not tested this thought, but I wanted to report this perceived issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions