Bug fix: passing other params to 'by id' endpoints.

Author: wenbinf

package.json

@@ -1,6 +1,6 @@
 {
   "name": "podcast-api",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "JavaScript bindings for the Listen Notes Podcast API",
   "main": "src/PodcastApiClient.js",
   "scripts": {

src/PodcastApiClient.js

@@ -37,14 +37,14 @@ const Client = (config = {}) => {
   this.fetchPodcastById = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/podcasts/${id}`, {
-      otherParams,
+      params: otherParams,
     });
   };
 
   this.fetchEpisodeById = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/episodes/${id}`, {
-      otherParams,
+      params: otherParams,
     });
   };
 
@@ -55,7 +55,7 @@ const Client = (config = {}) => {
   this.fetchCuratedPodcastsListById = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/curated_podcasts/${id}`, {
-      otherParams,
+      params: otherParams,
     });
   };
 
@@ -72,21 +72,21 @@ const Client = (config = {}) => {
   this.fetchRecommendationsForPodcast = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/podcasts/${id}/recommendations`, {
-      otherParams,
+      params: otherParams,
     });
   };
 
   this.fetchRecommendationsForEpisode = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/episodes/${id}/recommendations`, {
-      otherParams,
+      params: otherParams,
     });
   };
 
   this.fetchPlaylistById = (params) => {
     const { id, ...otherParams } = params;
     return this.httpClient.get(`/playlists/${id}`, {
-      otherParams,
+      params: otherParams,
     });
   };
 

tests/PodcastApiTest.js

@@ -118,7 +118,9 @@ test('Test fetchPodcastById with mock', () => {
     const podcastId = 'abcde';
     return client.fetchPodcastById({
         id: podcastId,
+        sort: 'oldest_first',
     }).then((response) => {
+        expect(response.config.params.sort).toBe('oldest_first');
         expect(response.config.url).toBe(`/podcasts/${podcastId}`);
         expect(response.config.method).toBe('get');
         expect(response.data.episodes.length > 0).toBe(true);
@@ -132,8 +134,10 @@ test('Test fetchEpisodeById with mock', () => {
     const episodeId = 'abc222de';
     return client.fetchEpisodeById({
         id: episodeId,
+        show_transcript: 1,
     }).then((response) => {
         expect(response.config.url).toBe(`/episodes/${episodeId}`);
+        expect(response.config.params.show_transcript).toBe(1);        
         expect(response.config.method).toBe('get');
         expect(response.data.podcast.rss.length > 0).toBe(true);
     }).catch(() => {