Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify INI file settings in DISPLAY section #3238

Open
hansu opened this issue Dec 23, 2024 · 11 comments
Open

Unify INI file settings in DISPLAY section #3238

hansu opened this issue Dec 23, 2024 · 11 comments

Comments

@hansu
Copy link
Member

hansu commented Dec 23, 2024

Follow up for #2335 and #3171

I started to list the INI-values that are used by the GUIs. Please help to fill the table with the GUIs you maintain.

ini-values.ods

Section Documentation (2.9) Gmoccapy Axis QTDragon Touchy glcanon (common)
AXIS_A WRAPPED_ROTARY WRAPPED_ROTARY
AXIS_B WRAPPED_ROTARY WRAPPED_ROTARY
AXIS_C WRAPPED_ROTARY WRAPPED_ROTARY
AXIS_X MAX_ACCELERATION MAX_ACCELERATION
AXIS_X MAX_VELOCITY MAX_VELOCITY
DISPLAY ANGULAR INCREMENTS ANGULAR INCREMENTS
DISPLAY ARCDIVISION - ARCDIVISION
DISPLAY BACK_TOOL_LATHE BACK_TOOL_LATHE
DISPLAY CONE_BASESIZE - CONE_BASESIZE
DISPLAY CYCLE_TIME CYCLE_TIME CYCLE_TIME
DISPLAY DEFAULT_ANGULAR_VELOCITY DEFAULT_ANGULAR_VELOCITY DEFUALT_ANGULAR_VELOCITY
DISPLAY DEFAULT_LINEAR_VELOCITY - DEFAULT_LINEAR_VELOCITY
DISPLAY DEFAULT_SPINDLE_0_SPEED - DEFAULT_SPINDLE_0_SPEED
DISPLAY DEFAULT_SPINDLE_SPEED DEFAULT_SPINDLE_SPEED DEFAULT_SPINDLE_SPEED
DISPLAY DISABLE_REPEAT_KEYS
DISPLAY DISPLAY - DISPLAY
DISPLAY DRO_FORMAT_IN - DRO_FORMAT_IN
DISPLAY DRO_FORMAT_MM - DRO_FORMAT_MM
DISPLAY EDITOR -
DISPLAY EMBED_TAB_COMMAND EMBED_TAB_COMMAND EMBED_TAB_COMMAND EMBED_TAB_COMMAND
DISPLAY - EMBED_TAB_LOCATION EMBED_TAB_LOCATION
DISPLAY EMBED_TAB_NAME EMBED_TAB_NAME EMBED_TAB_NAME EMBED_TAB_NAME
DISPLAY FOAM FOAM FOAM
DISPLAY FOAM_W FOAM_W
DISPLAY FOAM_Z FOAM_Z
DISPLAY GLADEFILE
DISPLAY GLADEVCP
DISPLAY GRAPHICS_CYCLE_TIME GRAPHICS_CYCLE_TIME
DISPLAY GEOMETRY GEOMETRY GEOMETRY
DISPLAY GRAPHICAL_MAX_FILE_SIZE GRAPHICAL_MAX_FILE_SIZE
DISPLAY GRIDS - GRIDS
DISPLAY HAL_CYCLE_TIME HAL_CYCLE_TIME
DISPLAY HELP_FILE -
DISPLAY ICON
DISPLAY INCREMENTS INCREMENTS INCREMENTS
DISPLAY INTRO_GRAPHIC -
DISPLAY INTRO_TIME -
DISPLAY JOG_AXES -
DISPLAY JOG_INVERT -
DISPLAY LATHE LATHE LATHE
DISPLAY - LATHE_WEAR_OFFSETS
DISPLAY LOG_FILE
DISPLAY MACHINE_LOG_FILE
DISPLAY MAX_ANGULAR_VELOCITY MAX_ANGULAR_VELOCITY MAX_ANGULAR_VELOCITY
DISPLAY MAX_DISPLAYED_ERRORS
DISPLAY MAX_FEED_OVERRIDE MAX_FEED_OVERRIDE MAX_FEEED_OVERRIDE
DISPLAY MAX_LINEAR_VELOCITY - MAX_LINEAR_VELOCITY
DISPLAY MAX_SPINDLE_0_OVERRIDE - MAX_SPINDLE_0_OVERRIDE
DISPLAY MAX_SPINDLE_0_SPEED - MAX_SPINDLE_0_SPEED
DISPLAY MAX_SPINDLE_OVERRIDE MAX_SPINDLE_OVERRIDE MAX_SPINDLE_OVERRIDE
DISPLAY MESSAGE_BOLD_TEXT MESSAGE_BOLD_TEXT
DISPLAY MESSAGE_DETAILS MESSAGE_DETAILS
DISPLAY MESSAGE_ICON MESSAGE_ICON
DISPLAY - MESSAGE_PINNAME MESSAGE_PINNAME
DISPLAY - MESSAGE_TEXT MESSAGE_TEXT
DISPLAY - MESSAGE_TYPE MESSAGE_TYPE
DISPLAY MDI_HISTORY_FILE - MDI_HISTORY_FILE
DISPLAY MIN_ANGULAR_VELOCITY MIN_ANGULAR_VELOCITY MIN_ANGULAR_VELOCITY
DISPLAY MIN_LINEAR_VELOCITY - MIN_LINEAR_VELOCITY
DISPLAY MIN_SPINDLE_0_OVERRIDE - MIN_SPINDLE_0_OVERRIDE
DISPLAY MIN_SPINDLE_0_SPEED - MIN_SPINDLE_0_SPEED
DISPLAY MIN_SPINDLE_OVERRIDE MIN_SPINDLE_OVERRIDE MIN_SPINDLE_OVERRIDE
DISPLAY MIN_VELOCITY -
DISPLAY MULTIMESSAGE_ID
DISPLAY MULTIMESSAGE_x_DETAILS
DISPLAY MULTIMESSAGE_x_ICON
DISPLAY MULTIMESSAGE_x_NUMBER
DISPLAY MULTIMESSAGE_x_OPTIONS
DISPLAY MULTIMESSAGE_x_TEXT
DISPLAY MULTIMESSAGE_x_TITLE
DISPLAY MULTIMESSAGE_x_TYPE
DISPLAY NGCGUI_SUBFILE_PATH
DISPLAY NGCGUI_SUBFILE
DISPLAY OPEN_FILE -
DISPLAY POSITION_FEEDBACK POSITION_FEEDBACK
DISPLAY POSITION_OFFSET -
DISPLAY PREVIEW_TIMEOUT -
DISPLAY - PREFERENCE_FILE_PATH PREFERENCE_FILE_PATH
DISPLAY PROGRAM_PREFIX PROGRAM_PREFIX PROGRAM_PREFIX
DISPLAY PYVCP -
DISPLAY PYVCP_POSITION -
DISPLAY SPINDLE_INCREMENT - SPINDLE_INCREMENT
DISPLAY TOOL_EDITOR -
DISPLAY USER_COMMAND_FILE USER_COMMAND_FILE USER_COMMAND_FILE
DISPLAY - USER_CSS_FILE
FILTER PROGRAM_EXTENSION PROGRAM_EXTENSION
HAL POSTGUI_HALFILE POSTGUI_HALFILE POSTGUI_HALFILE POSTGUI_HALFILE
HAL POSTGUI_HALCMD
JOINT_0 UNITS
JOINT_x HOME_SEQUENCE
JOINT_x TYPE
KINS JOINTS JOINTS JOINTS
KINS KINEMATICS KINEMATICS KINEMATICS KINEMATICS
MACROS - MACRO MACRO MACRO
MDI_COMMAND_LIST MDI_COMMAND_xxxx
MDI_COMMAND_LIST MDI_COMMAND_string
TRAJ COORDINATES
TRAJ DEFAULT_LINEAR_VELOCITY
TRAJ LINEAR_UNITS LINEAR_UNITS
TRAJ MAX_LINEAR_VELOCITY MAX_LINEAR_VELOCITY
TRAJ NO_FORCE_HOMING NO_FORCE_HOMING
TRAJ SPINDLES
@c-morley
Copy link
Collaborator

updated for Qtvcp. If you look at gremlin.py there are more INI settings for gmoccapy too.
ini-values.ods

@hansu
Copy link
Member Author

hansu commented Dec 28, 2024

Thanks. I will have a look into gremlin.py :-)

@andypugh
Copy link
Collaborator

I am not actually the Touchy maintainer, but I do use it. It seems to take very little from the INI

andypugh@rm-one:~/linuxcnc-dev/src/emc/usr_intf/touchy$ grep -r ini.find .
./touchy.py:                        alternate_gladefile = self.ini.find("DISPLAY", "GLADEFILE")
./touchy.py:                    macros = self.ini.findall("TOUCHY", "MACRO")
./touchy.py:                units=self.ini.find("TRAJ","LINEAR_UNITS")
./touchy.py:                        units=self.ini.find("AXIS_X","UNITS")
./touchy.py:                tab_names = self.ini.findall("DISPLAY", "EMBED_TAB_NAME")
./touchy.py:                tab_cmd   = self.ini.findall("DISPLAY", "EMBED_TAB_COMMAND")
./touchy.py:                postgui_halfile = self.ini.findall("HAL", "POSTGUI_HALFILE") or None
./touchy.py:                kins = self.ini.find("KINS", "KINEMATICS")

@hansu
Copy link
Member Author

hansu commented Dec 31, 2024

I am not actually the Touchy maintainer, but I do use it. It seems to take very little from the INI

Touchy could also get some clean up for

  • "TOUCHY", "MACRO"
  • "AXIS_X","UNITS"

@andypugh
Copy link
Collaborator

andypugh commented Jan 4, 2025

Are you suggesting that Touchy should search in [MACROS] rather than in [TOUCHY] ?
Or both?

Looking at [AXIS_X] for units probably isn't ideal as that appears to be a JOINT_n setting, and is intended as an override. (according to the docs)

@hansu
Copy link
Member Author

hansu commented Jan 5, 2025

Are you suggesting that Touchy should search in [MACROS] rather than in [TOUCHY] ? Or both?

Yes in [MACROS] only. And we should convert it with the update-ini script.

Looking at [AXIS_X] for units probably isn't ideal as that appears to be a JOINT_n setting, and is intended as an override. (according to the docs)

Then maybe [TRAJ] LINEAR_UNITS is the better choice.

@andypugh
Copy link
Collaborator

andypugh commented Jan 5, 2025

Are you suggesting that Touchy should search in [MACROS] rather than in [TOUCHY] ? Or both?
Yes in [MACROS] only. And we should convert it with the update-ini script.

OK.

Looking at [AXIS_X] for units probably isn't ideal as that appears to be a JOINT_n setting, and is intended as an override. (according to the docs)
Then maybe [TRAJ] LINEAR_UNITS is the better choice.

It looks in [TRAJ] first.

@hansu
Copy link
Member Author

hansu commented Jan 5, 2025

It looks in [TRAJ] first.

Oh yes I overlooked that

@andypugh
Copy link
Collaborator

andypugh commented Jan 5, 2025

f0e693a and 14fd201

@hansu
Copy link
Member Author

hansu commented Jan 6, 2025

Nice 👍
I only wonder if it was your intention to update "updating-linuxcnc.adoc" with this commit?

@andypugh
Copy link
Collaborator

andypugh commented Jan 6, 2025

Nice 👍 I only wonder if it was your intention to update "updating-linuxcnc.adoc" with this commit?

Yes, this is the first config change (that I am aware of) between 2.9 and 2.10. I thought that it was probably better to do it with a release-note and a warning from the GUI rather than add it to the update_ini script, at least at this point in time. (it seems like a waste of an ini-version increment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants