Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving the option of updating gpCAM using a grid of points #1213

Merged
merged 14 commits into from
Feb 7, 2024
Merged

Conversation

jmlarson1
Copy link
Member

No description provided.

@jmlarson1 jmlarson1 marked this pull request as ready for review January 4, 2024 21:16
@jmlarson1 jmlarson1 requested a review from shuds13 January 4, 2024 21:16
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (a02b0b6) 72.38% compared to head (7fe8bd4) 71.78%.
Report is 10 commits behind head on develop.

Files Patch % Lines
libensemble/gen_funcs/persistent_gpCAM.py 0.00% 85 Missing ⚠️
libensemble/executors/executor.py 50.00% 3 Missing and 1 partial ⚠️
libensemble/worker.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1213      +/-   ##
===========================================
- Coverage    72.38%   71.78%   -0.61%     
===========================================
  Files           93       93              
  Lines         8275     8349      +74     
  Branches      1487     1505      +18     
===========================================
+ Hits          5990     5993       +3     
- Misses        2035     2106      +71     
  Partials       250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuds13
Copy link
Member

shuds13 commented Jan 8, 2024

@jmlarson1

Possible optimizations for _find_eligible_points?

  • sorted_X is not really used - so can remove
  • sorted_indices and sorted_D look like they are invariant within a batch so calc outside while loop (line 143).
  • Not sure the deep copies are necessary?

I can make these changes if they make sense - 2x in regression test.

@shuds13 shuds13 mentioned this pull request Feb 7, 2024
20 tasks
@shuds13 shuds13 merged commit d536637 into develop Feb 7, 2024
13 of 16 checks passed
@jmlarson1 jmlarson1 deleted the gpCAM_grid branch February 8, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants