[stk/ascraeus] Split constants

Properly define global constants in constant files and separate
dynamic and static constants.

Author: Erik Frèrejean

stk/includes/bootstrap.php

@@ -9,24 +9,7 @@
 
 $starttime = microtime(true);
 
-// Define some initial constants
-if (!defined('STK_ROOT'))
-{
-	define('STK_ROOT', __DIR__ . '/../');
-}
-
-if (!defined('PHPBB_FILES'))
-{
-	define('PHPBB_FILES', STK_ROOT . 'phpBB/');
-}
-
-if (!defined('IN_PHPBB'))
-{
-	define('IN_PHPBB', true);
-}
-
-// Enforce the usage of the SID
-define('NEED_SID', true);
+require (__DIR__ . '/static_constants.php');
 
 // Setup the DI container
 require STK_ROOT . 'core/Pimple.php';
@@ -246,4 +229,4 @@
 $stk['phpbb']['style']->set_custom_style();
 
 // Include some STK files that can't be autoloaded
-require STK_ROOT . 'includes/constants.php';
+require STK_ROOT . 'includes/dynamic_constants.php';

stk/includes/constants.php stk/includes/dynamic_constants.php

@@ -7,12 +7,5 @@
  *
  */
 
-// Version constants
-define('STK_VERSION', '2.0.0-dev');
-define('STK_QA', true);
-
 // The web path
 define('STK_WEB_PATH', generate_board_url(true));
-
-// Tool options
-define('TOOL_OVERVIEW_TRIGGER', 1);

stk/includes/static_constants.php

@@ -0,0 +1,34 @@
+<?php
+/**
+ *
+ * @package SupportToolkit
+ * @copyright (c) 2012 phpBB Group
+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+ *
+ */
+
+// Define some initial constants
+if (!defined('STK_ROOT'))
+{
+	define('STK_ROOT', __DIR__ . '/../');
+}
+
+if (!defined('PHPBB_FILES'))
+{
+	define('PHPBB_FILES', STK_ROOT . 'phpBB/');
+}
+
+if (!defined('IN_PHPBB'))
+{
+	define('IN_PHPBB', true);
+}
+
+// Version constants
+define('STK_VERSION', '2.0.0-dev');
+define('STK_QA', true);
+
+// Enforce the usage of the SID
+define('NEED_SID', true);
+
+// Tool options
+define('TOOL_OVERVIEW_TRIGGER', 1);