updating test cases

Author: jsagardoy

.vscode/launch.json

@@ -1,16 +0,0 @@
-{
-    // Use IntelliSense para saber los atributos posibles.
-    // Mantenga el puntero para ver las descripciones de los existentes atributos 
-    // Para más información, visite: https://go.microsoft.com/fwlink/?linkid=830387
-    "version": "0.2.0",
-    "configurations": [
-        
-        {
-            "type": "chrome",
-            "request": "launch",
-            "name": "Lanzar Chrome contra localhost",
-            "url": "http://localhost:8080",
-            "webRoot": "${workspaceFolder}"
-        }
-    ]
-}

13 TestComponents/src/components/member/page.spec.tsx

@@ -1,21 +1,16 @@
 import * as React from 'react';
 import {MemberPage, Props} from './page';
 import * as SaveMember from './actions/saveMember';
-import {saveMemberAction} from './actions/saveMember';
 import {shallow} from 'enzyme';
 import { createEmptyMember } from '../../reducers/member';
 import { createEmptyMemberErrors } from '../../reducers/memberErrors';
 import { MemberEntity } from '../../model';
-import configureStore from 'redux-mock-store';
-import reduxThunk from 'redux-thunk';
 
-const middlewares = [reduxThunk];
-const getMockStore = configureStore(middlewares);
 
 describe ('/components/member/page specs',()=>{
     it('should retur as expected when definde props',()=>{
         //arrange
-        const data:Props = {
+        const props:Props = {
             memberId:-1,
             member: createEmptyMember(),
             memberErrors: createEmptyMemberErrors(),
@@ -25,7 +20,7 @@ describe ('/components/member/page specs',()=>{
         }
         //act
         const component = shallow (
-            <MemberPage {...data} />
+            <MemberPage {...props} />
         );
         //assert
         expect(component).toMatchSnapshot();
@@ -38,58 +33,84 @@ describe ('/components/member/page specs',()=>{
             avatar_url:'test new avatar',
             login: 'test new login'
         }
-        const data: Props = {
+        const props: Props = {
             memberId: -1,
-            member: createEmptyMember(),
+            member: newMember,
             memberErrors: createEmptyMemberErrors(),
             fetchMemberById: () => { },
             onChange: () => { },
             onSave: jest.fn(),
         }
-        const store = getMockStore();
+       
 
         const actionSaveStub = jest.spyOn(SaveMember, 'saveMemberAction')
              .mockImplementation(()=>(
                { ...newMember,}
             ));
 
         const component = shallow(
-            <MemberPage {...data} />,
-            {
-            context: { store },
-            },
+            <MemberPage {...props} />,
         );
 
 
-        component.prop('onSave')();
-        console.log(`pete ${component}`);
+        //component.prop('onSave')();
+        component.simulate('save',newMember);
+       
         //assert
-        expect(actionSaveStub).toHaveBeenCalledWith(newMember);
+        expect(props.onSave).toHaveBeenCalledWith(newMember);
 
     });
 
-    /* it('should call onChange when Changes are made', () => {
+    it('should call onChange when Changes are made', () => {
         //arrange
 
-        const data: Props = {
+         const newMember: MemberEntity = {
+             id: 56789,
+             avatar_url: 'test new avatar',
+             login: 'test new login'
+         }
+        const props: Props = {
             memberId: -1,
-            member: createEmptyMember(),
+            member: newMember,
             memberErrors: createEmptyMemberErrors(),
             fetchMemberById: () => { },
             onChange: jest.fn(),
             onSave: () => { } ,
         }
 
+        let fieldName =  'test fieldName';
+        let value =  'test value';
 
         //act
         const component = shallow(
-            <MemberPage {...data} />
+            <MemberPage {...props} />
         );
 
 
-        component.find('data.onChange');
+         component.simulate('change', fieldName, value);
         //assert
-        expect(component).toHaveBeenCalled();
+         expect(props.onChange).toHaveBeenCalledWith(newMember,fieldName, value);
+
+    }); 
+    it ('should componetDidMount when component is called',()=>{
+        //arrange
+        const props: Props = {
+            memberId: -1,
+            member: createEmptyMember(),
+            memberErrors: createEmptyMemberErrors(),
+            fetchMemberById: jest.fn(),
+            onChange: ()=>{},
+            onSave: () => { },
+        }
 
-    }); */
+        //act
+        const component = shallow(
+            <MemberPage {...props} />
+        );
+
+        component.find('componentDidMount');
+       
+        //assert
+        expect (props.fetchMemberById).toHaveBeenCalled();
+    });
 });

13 TestComponents/src/components/member/pageContainer.spec.tsx

@@ -9,8 +9,6 @@ import {createEmptyMemberErrors} from '../../reducers/memberErrors';
 import * as MemberFieldChange from './actions/memberFieldChange';
 import * as SaveMember from './actions/saveMember';
 
-
-
 const getMockStore = configureStore();
 
 describe('pages/login/pageContainer tests', () => {

13 TestComponents/src/components/members/__snapshots__/memberHeader.spec.tsx.snap

@@ -0,0 +1,15 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`./components/members/memberHeader should render memberHeader as expected 1`] = `
+<tr>
+  <th>
+    Avatar
+  </th>
+  <th>
+    Id
+  </th>
+  <th>
+    Name
+  </th>
+</tr>
+`;

13 TestComponents/src/components/members/__snapshots__/memberRow.spec.tsx.snap

@@ -0,0 +1,23 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`/components/members/memberRow should render as expected whenprops are passed 1`] = `
+<tr>
+  <td>
+    <img
+      className="avatar"
+      src=""
+    />
+  </td>
+  <td>
+    <Link
+      replace={false}
+      to="/member/-1"
+    >
+      -1
+    </Link>
+  </td>
+  <td>
+    <span />
+  </td>
+</tr>
+`;

13 TestComponents/src/components/members/__snapshots__/pageContainer.spec.tsx.snap

@@ -0,0 +1,8 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`/components/members/pageContainer should render as spected passing state 1`] = `
+<MembersPage
+  fetchMembers={[Function]}
+  members={Array []}
+/>
+`;

13 TestComponents/src/components/members/memberHeader.spec.tsx

@@ -0,0 +1,16 @@
+import * as React  from 'react';
+import {MemberHeader} from './memberHeader';
+import {shallow} from 'enzyme';
+
+describe('./components/members/memberHeader',()=>{
+    it('should render memberHeader as expected',()=>{
+        //arrange
+        //act
+        const component =  shallow(
+            <MemberHeader />
+        );
+        //Assert
+        expect (component).toMatchSnapshot();
+
+    });
+});

13 TestComponents/src/components/members/memberRow.spec.tsx

@@ -0,0 +1,18 @@
+import * as React from 'react';
+import {MemberRow,Props} from './memberRow';
+import {shallow} from 'enzyme';
+import { createEmptyMember } from '../../reducers/member';
+
+describe('/components/members/memberRow',()=>{
+    it('should render as expected whenprops are passed',()=>{
+        //arrange    
+        let member: Props = {member:createEmptyMember()};
+        //act
+            let component = shallow(    
+                <MemberRow{...member}/>
+            );
+        //assert
+        expect (component).toMatchSnapshot();
+    });
+})
+

13 TestComponents/src/components/members/memberRow.tsx

@@ -2,7 +2,7 @@ import * as React from 'react';
 import { Link } from 'react-router-dom';
 import { MemberEntity } from '../../model';
 
-interface Props {
+export interface Props {
   member: MemberEntity;
 }
 

13 TestComponents/src/components/members/pageContainer.spec.tsx

@@ -0,0 +1,32 @@
+import * as React from 'react';
+import { shallow } from 'enzyme';
+import { State } from '../../reducers';
+import configureStore from 'redux-mock-store';
+import { createEmptyMembers } from '../../reducers/members';
+import { createEmptyMember } from '../../reducers/member';
+import { createEmptyMemberErrors } from '../../reducers/memberErrors';
+import { MembersPageContainer } from './pageContainer';
+
+const getMockStore = configureStore();
+
+describe('/components/members/pageContainer', () => {
+    it('should render as spected passing state',()=>{
+        //arrange
+        const state = {
+            members: createEmptyMembers(),
+            member: createEmptyMember(),
+            memberErrors: createEmptyMemberErrors()
+        } as State;
+        const store = getMockStore(state);
+        //act
+        
+        const component =  shallow(
+            <MembersPageContainer/>,
+            {
+                context: {store},
+            },
+        );
+        //assert
+        expect(component).toMatchSnapshot();
+    });
+});