feat(ikari): remove unnecessary setup

Author: runjuu

src/core/ikari.ts

@@ -77,7 +77,6 @@ export class Ikari<State> {
       return createdIkari
     } else {
       const ikari = new Ikari(config)
-      ikari.setup()
       Reflect.defineMetadata(ikariSymbol, ikari, target)
       return ikari
     }
@@ -95,17 +94,9 @@ export class Ikari<State> {
 
   subscription = new Subscription()
 
-  private isSetup: boolean = false
-
   constructor(private readonly config: Readonly<Config<State>>) {
     this.effectActionFactories = config.effectActionFactories
     this.state = new BasicState<State>(config.defaultState)
-  }
-
-  setup() {
-    if (this.isSetup) {
-      return
-    }
 
     const [effectActions$, effectActions] = setupEffectActions(
       this.config.effects,
@@ -136,8 +127,6 @@ export class Ikari<State> {
         this.handleAction(action)
       }),
     )
-
-    this.isSetup = true
   }
 
   destroy() {

test/specs/ikari.spec.ts

@@ -41,25 +41,9 @@ describe('Ikari spec:', () => {
     })
   })
 
-  describe('setup', () => {
+  describe('instance', () => {
     const ikari = createIkari()
 
-    it('`setup` actually run once', () => {
-      ikari.setup()
-      const firstTriggerActions = ikari.triggerActions
-
-      ikari.setup()
-      const secondTriggerActions = ikari.triggerActions
-
-      expect(firstTriggerActions).toBe(secondTriggerActions)
-    })
-  })
-
-  describe('after setup', () => {
-    const ikari = createIkari()
-
-    ikari.setup()
-
     it('state is setup properly', () => {
       expect(ikari.state).toBeInstanceOf(BasicState)
       expect(ikari.state.getState()).toEqual({ count: 0 })
@@ -81,8 +65,6 @@ describe('Ikari spec:', () => {
   describe('after destroy', () => {
     const ikari = createIkari()
 
-    ikari.setup()
-
     expect(ikari.subscription.closed).toBe(false)
 
     beforeEach(() => {
@@ -96,11 +78,5 @@ describe('Ikari spec:', () => {
     it('should remove all triggerActions', () => {
       expect(ikari.triggerActions).toEqual({})
     })
-
-    it('should not able to reactive', () => {
-      ikari.setup()
-      expect(ikari.subscription.closed).toBe(true)
-      expect(ikari.triggerActions).toEqual({})
-    })
   })
 })