Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No $this->property and $this->getProperty() mix. #154

Open
LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Open

No $this->property and $this->getProperty() mix. #154

LastDragon-ru opened this issue Apr 25, 2024 · 0 comments
Assignees
@LastDragon-ru
Labels
! Breaking change scope: refactor

Comments

@LastDragon-ru
Copy link
Owner

LastDragon-ru commented Apr 25, 2024 •
edited
Loading

The new code usually uses (readonly) $this->property, the old code prefer $this->getProperty(). Only one style should be used. And the winner is $this->getProperty() (because it can be mocked) protected readonly $property.
@LastDragon-ru LastDragon-ru added scope: refactor ! Breaking change labels Apr 25, 2024
@LastDragon-ru LastDragon-ru added this to the Next milestone Apr 25, 2024
@LastDragon-ru LastDragon-ru self-assigned this Apr 25, 2024
@LastDragon-ru LastDragon-ru mentioned this issue Apr 28, 2024
Merged
LastDragon-ru added a commit that referenced this issue Apr 28, 2024
@LastDragon-ru
feat(testing): Properties mocks (Mockery; mockery/mockery#1142) (#156)
54330d4 
Related to #154
@LastDragon-ru LastDragon-ru removed this from the NextMajor milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LastDragon-ru LastDragon-ru

Labels
! Breaking change scope: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LastDragon-ru