Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request #32

Open
Ph4i1ur3 opened this issue Aug 7, 2023 · 3 comments
Open

Request #32

Ph4i1ur3 opened this issue Aug 7, 2023 · 3 comments

Comments

@Ph4i1ur3
Copy link

Ph4i1ur3 commented Aug 7, 2023

Would it be possible to make _sortedBackpackSizes accessible via the API? Would make plugins like "Backpack Upgrader" able to read the new permission system without Reflection

@WheteThunger
Copy link
Collaborator

I'll consider this suggestion. However, I'm skeptical that plugins such as Backpack Upgrader should be granting/revoking permissions at all.

One design under consideration is to introduce a new mode to the Backpacks plugin where permissions are only used to assign capacity rulesets to players. A ruleset would define the minimum and maximum capacity. The actual capacity for a player would be stored by the Backpacks plugin in a data file, and that stored capacity could be optionally cleared when the map wipes. Other plugins such as Backpack Upgrader could call Backpacks APIs to determine the player's current/min/max capacity, as well as to increase or decrease the capacity

@WheteThunger
Copy link
Collaborator

I implemented something for this on a branch of my fork. Search the docs for "Dynamic size".

https://github.com/WheteThunger/Backpacks/tree/capacity-management

Would you be interested in experimenting with it? It will require integration work on the Backpack Upgrader side.

@Ph4i1ur3
Copy link
Author

I'll test it out and report back, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants