New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate `couplingScheme::m_numTotalNodes` #106

Open

ebchin opened this issue Oct 3, 2024 · 0 comments

Member

ebchin commented Oct 3, 2024

This appears to hold the number of nodes on mesh1 (the mortar mesh) (see https://github.com/LLNL/Tribol/blob/develop/src/tribol/mesh/CouplingScheme.cpp#L1114). This is not apparent from the name of the variable and appears to be used only with the mortar method. Consider

Moving this variable to the method data
Renaming it to something more accurate and verifying it's usage is as intended in the code

ebchin changed the title ~~Investigate couplingScheme::m_numTotalNodes~~ Investigate couplingScheme::m_numTotalNodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment