Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicks don't always make it through nm-applet submenu when it's in the sfwbar systray #230

Open
jjramsey opened this issue Sep 7, 2024 · 4 comments

Comments

@jjramsey
Copy link

jjramsey commented Sep 7, 2024

I run nm-applet at startup, and its applet icon appears, as it should, in sfwbar's system tray.

If I right-click on the applet icon, go to the "Available networks" submenu of that applet, and then click on an item from that submenu to choose a wireless network, it's hit-or-miss whether a dialog will come up asking to connect to the network. I've seen this issue with sfwbar on Hyprland, Sway, and LabWC. As a point of comparison, I've tested this on waybar and not seen a similar problem with the system tray.

@LBCrion
Copy link
Owner

LBCrion commented Sep 7, 2024

I think I see the issue. nm-applet updates the menu while it's open, changing the item id's used for activation. Fixing this would require some refactoring of sni menu support, but shouldn't be too hard. Give me a few days please.

@LBCrion
Copy link
Owner

LBCrion commented Sep 11, 2024

I just pushed the commit that hopefully fixes the issue. Please let me know if you see any issues with the tray item menus on the back of this change as I pretty much had to completely rewrite the tray item menu code :)

@01micko
Copy link

01micko commented Sep 12, 2024

Confirmed fixed here, tested all options.

@jjramsey
Copy link
Author

jjramsey commented Sep 13, 2024

Looks good to me so far.

ETA: Sometimes right-clicking the tray icon doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants