Skip to content

Commit d2e866f

Browse files
committed
Ignore the return value from ack_keys.
Resolves: riak_kv_index_fsm.erl:127: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_index_fsm.erl:134: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_index_fsm.erl:191: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_keys_fsm.erl:104: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_pb_bucket.erl:129: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_pb_bucket.erl:136: Expression produces a value of type {_,'ok'}, but this value is unmatched riak_kv_pipe_listkeys.erl:102: Expression produces a value of type {_,'ok'}, but this value is unmatched
1 parent 082f688 commit d2e866f

4 files changed

+7
-7
lines changed

src/riak_kv_index_fsm.erl

+3-3
Original file line numberDiff line numberDiff line change
@@ -124,14 +124,14 @@ process_results(VNode, {From, Bucket, Results}, State) ->
124124
VNodeCount = dict:fetch(VNode, PerNode),
125125
case VNodeCount < MaxResults of
126126
true ->
127-
riak_kv_vnode:ack_keys(From),
127+
_ = riak_kv_vnode:ack_keys(From),
128128
{ok, State2};
129129
false ->
130130
riak_kv_vnode:stop_fold(From),
131131
{done, State2}
132132
end;
133133
{ok, State2} ->
134-
riak_kv_vnode:ack_keys(From),
134+
_ = riak_kv_vnode:ack_keys(From),
135135
{ok, State2};
136136
{done, State2} ->
137137
riak_kv_vnode:stop_fold(From),
@@ -188,7 +188,7 @@ process_results({error, Reason}, _State) ->
188188
process_results({From, Bucket, Results},
189189
StateData=#state{from={raw, ReqId, ClientPid}}) ->
190190
process_query_results(Bucket, Results, ReqId, ClientPid),
191-
riak_kv_vnode:ack_keys(From), % tell that vnode we're ready for more
191+
_ = riak_kv_vnode:ack_keys(From), % tell that vnode we're ready for more
192192
{ok, StateData};
193193
process_results({Bucket, Results},
194194
StateData=#state{from={raw, ReqId, ClientPid}}) ->

src/riak_kv_keys_fsm.erl

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ process_results({From, Bucket, Keys},
101101
%% TODO: have caller give us the Idx number.
102102
?DTRACE(?C_KEYS_PROCESS_RESULTS, [length(Keys)], []),
103103
process_keys(Bucket, Keys, ReqId, ClientPid),
104-
riak_kv_vnode:ack_keys(From), % tell that vnode we're ready for more
104+
_ = riak_kv_vnode:ack_keys(From), % tell that vnode we're ready for more
105105
{ok, StateData};
106106
process_results({error, Reason}, _State) ->
107107
?DTRACE(?C_KEYS_PROCESS_RESULTS, [-1], []),

src/riak_kv_pb_bucket.erl

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,14 @@ process_stream({ReqId, done}, ReqId,
126126
{done, #rpblistkeysresp{done = 1}, State};
127127
process_stream({ReqId, From, {keys, []}}, ReqId,
128128
State=#state{req=#rpblistkeysreq{}, req_ctx=ReqId}) ->
129-
riak_kv_keys_fsm:ack_keys(From),
129+
_ = riak_kv_keys_fsm:ack_keys(From),
130130
{ignore, State};
131131
process_stream({ReqId, {keys, []}}, ReqId,
132132
State=#state{req=#rpblistkeysreq{}, req_ctx=ReqId}) ->
133133
{ignore, State};
134134
process_stream({ReqId, From, {keys, Keys}}, ReqId,
135135
State=#state{req=#rpblistkeysreq{}, req_ctx=ReqId}) ->
136-
riak_kv_keys_fsm:ack_keys(From),
136+
_ = riak_kv_keys_fsm:ack_keys(From),
137137
{reply, #rpblistkeysresp{keys = Keys}, State};
138138
process_stream({ReqId, {keys, Keys}}, ReqId,
139139
State=#state{req=#rpblistkeysreq{}, req_ctx=ReqId}) ->

src/riak_kv_pipe_listkeys.erl

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ keysend_loop(ReqId, Partition, FittingDetails) ->
9999
Result = keysend(Bucket, Keys, Partition, FittingDetails),
100100
case Result of
101101
ok ->
102-
riak_kv_vnode:ack_keys(From),
102+
_ = riak_kv_vnode:ack_keys(From),
103103
keysend_loop(ReqId, Partition, FittingDetails);
104104
Error ->
105105
Error

0 commit comments

Comments
 (0)