Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional customization settings #8

Open
huphtur opened this issue Aug 18, 2020 · 1 comment
Open

Add additional customization settings #8

huphtur opened this issue Aug 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@huphtur
Copy link

huphtur commented Aug 18, 2020

Possible to pass settings to the autoEmbed (click on set customization options on this page to see the embed settings)?

  • Theme: Light or Dark (default to light).
  • Language: Default to Auto Detect I assume.
  • Hide Conversation: True or False (default to false).
  • Do Not Track: True or False. Default to false please!
@KyleMit KyleMit added the enhancement New feature or request label Aug 19, 2020
@KyleMit
Copy link
Owner

KyleMit commented Aug 19, 2020

So we only invoke the twitter publish API as a fallback if we can't actually hit the server and build our own. After we get the json payload, everything is built individually.

  • Light/Dark styles won't come for free, but certainly should be able to code up in CSS.
  • Hide conversation will be a little trickier since we'll have to template out the conversation based on the data. Plausible, but might decouple from the other customizations
  • Do not track - we can pass this in the fallback scenario, but currently nothing is tracked because there's no client side JS - so twitter doesn't get a say

Thanks for the suggestions, I can definitely see some of the customization options making their way in

@KyleMit KyleMit changed the title REQ: autoEmbed customization settings. Add additional customization settings Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants